Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove vendored bazel-skylib used by ts_project #3207

Merged
merged 1 commit into from
Jan 10, 2022
Merged

chore: remove vendored bazel-skylib used by ts_project #3207

merged 1 commit into from
Jan 10, 2022

Conversation

alexeagle
Copy link
Collaborator

Users now have the dependency on bazel-skylib so we can just load from there

@alexeagle
chore: remove vendored bazel-skylib used by ts_project
f47ec35 
Users now have the dependency on bazel-skylib so we can just load from there
@kormide
Copy link
Collaborator

kormide commented Jan 10, 2022

What's the historical context on this one?

@alexeagle
Copy link
Collaborator Author

Prior to 5.x, build_bazel_rules_nodejs had no starlark module dependencies, so we couldn't rely on users having @bazel_skylib installed. https://github.com/bazelbuild/rules_nodejs/wiki/Migrating-to-5.0 goes into it a bit. Also #3174

@alexeagle alexeagle merged commit fa84c43 into 5.x Jan 10, 2022
@alexeagle alexeagle deleted the cleanup1 branch January 10, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @kormide