refactor: use new toolchain for nodejs_binary #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
alexeagle
force-pushed
the
toolchain_prefactor2
branch
2 times, most recently
from
ac917e3 to
07be662
Compare
alexeagle
force-pushed
the
toolchain_prefactor2
branch
10 times, most recently
from
c7f3389 to
e9a4f23
Compare
alexeagle
force-pushed
the
toolchain_prefactor2
branch
from
e9a4f23 to
d6c128f
Compare
gregmagolan
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another usage of hardcoded @nodejs removed