fix(builtin): pkg_npm shouldn't assume the name of the nodejs toolchain #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
alexeagle
force-pushed
the
pkg_npm_toolchain
branch
7 times, most recently
from
d818825 to
e8d6923
Compare
alexeagle
force-pushed
the
pkg_npm_toolchain
branch
3 times, most recently
from
cfe8dd5 to
be2f062
Compare
alexeagle
force-pushed
the
pkg_npm_toolchain
branch
from
be2f062 to
a115b43
Compare
gregmagolan
reviewed
Dec 22, 2021
Instead it should just ask the resolved toolchain for the info it needs
alexeagle
force-pushed
the
pkg_npm_toolchain
branch
from
a115b43 to
4034eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead it should just ask the resolved toolchain for the info it needs