Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add arm64 as a platform to //packages/concatjs:docs_scrub_platform #3089

Merged
merged 2 commits into from
Nov 19, 2021
Merged

fix: add arm64 as a platform to //packages/concatjs:docs_scrub_platform #3089

merged 2 commits into from
Nov 19, 2021

Conversation

CooperBills
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

bazel test //docs:check_concatjs fails on an M1 mac (Darwin arm64) host, as only the amd64 platform is scrubbed from the docs.

Issue Number: #3085

What is the new behavior?

Both amd64 and arm64 will be scrubbed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Nov 19, 2021
@alexeagle alexeagle merged commit bc2803a into bazel-contrib:stable Nov 19, 2021
@CooperBills CooperBills mentioned this pull request Nov 19, 2021
Closed
5 tasks
@CooperBills CooperBills deleted the cbills/arm64-platform-scrub branch November 19, 2021 19:19
alexeagle pushed a commit that referenced this pull request Dec 3, 2021
@CooperBills @alexeagle
fix: add arm64 as a platform to //packages/concatjs:docs_scrub_platfo…
8161dcc 
…rm (#3089)

* fix: add arm64 as a platform to //packages/concatjs:docs_scrub_platform

* fix: combine platform scrub to single sed cmd
@renovate renovate bot mentioned this pull request Jul 9, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CooperBills @alexeagle