fix: update tsconfigs to include darwin_arm64-fastbuild in rootDirs #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CooperBills
requested review from
alexeagle,
gregmagolan,
jbedard,
mattem,
mrmeku and
soldair
as code owners
alexeagle
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ts output files cannot be found when building test and example code on an M1 Mac (Darwin arm64) host. This is because the
tsconfig.jsonfiles look in specificbazel-outdirectories, anddarwin_arm64-fastbuildis not on that list.Issue Number: #3085
What is the new behavior?
darwin_arm64-fastbuildwill be included in typescript's search for output files.Does this PR introduce a breaking change?
Other information