chore: update bazel/create package #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexeagle
commented
May 9, 2021
alexeagle
commented
- put deps in a separate file
- don't name WORKSPACE.bazel due to bug
alexeagle
force-pushed
the
strictDeps
branch
2 times, most recently
from
c47d85f to
da40cdc
Compare
mattem
reviewed
May 10, 2021
packages/create/index.js
Outdated
|
|
||
| ${pkgMgr === 'yarn' ? yarnInstallCmd : npmInstallCmd}`; | ||
|
|
||
| write('WORKSPACE.bazel', workspaceContent); | ||
| write('.bazelignore', `node_modules | ||
| write('tools/BUILD.bazel', '# No targets in this Bazel package\n') |
There was a problem hiding this comment.
nit: "No targets in this Bazel package" makes it seem to me that it's not valid to put targets in the root package, rather than saying that this package is currently empty?
mattem
approved these changes
May 10, 2021
Wenqer
reviewed
May 10, 2021
| write('.bazelignore', `node_modules | ||
| write('tools/BUILD.bazel', '# No targets in this Bazel package\n') | ||
| write('tools/bazel_deps.bzl', bazelDepsContent); | ||
| // Don't name it WORKSPACE.bazel since there's a bug with managed_directories |
There was a problem hiding this comment.
@alexeagle could you please share more details about this bug? Does it mean that "workspace" file should be used always without .bazel extension, or it affects only bazel/create package?
There was a problem hiding this comment.
@gregmagolan is tracking down the bug which hasn't been filed upstream yet. It affects everyone, not just this bazel/create package.
- put deps in a separate file - don't name WORKSPACE.bazel due to bug
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
- put deps in a separate file - don't name WORKSPACE.bazel due to bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.