feat(builtin): add js_library JSEcmaScriptModuleInfo support #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
js_library_ecma-provider
branch
from
a18acf3 to
4c895ad
Compare
alexeagle
approved these changes
May 7, 2021
jbedard
force-pushed
the
js_library_ecma-provider
branch
from
4c895ad to
5ff9499
Compare
jbedard
force-pushed
the
js_library_ecma-provider
branch
from
5ff9499 to
7d53b6f
Compare
jbedard
commented
May 9, 2021
| @@ -254,7 +254,8 @@ def _rollup_bundle(ctx): | |||
| for dep in ctx.attr.deps: | |||
| if JSEcmaScriptModuleInfo in dep: | |||
| deps_depsets.append(dep[JSEcmaScriptModuleInfo].sources) | |||
| elif JSModuleInfo in dep: | |||
There was a problem hiding this comment.
This seems to fix the internal/pkg_npm/test:test_pkg test, and I don't understand why..?
Why is the esbuild dep collection so different from the rollup version? Without this change pkg_npm/test:test_pkg fails because the outputted files have slight changes (a single exports.X = undefined (or void?) and the sourcemap change).
There was a problem hiding this comment.
The other failing before this change was packages/rollup/test/integration. Somehow this only failed on CI and not locally though!? The error was
Compilation failed Error: '@far/a' is imported by packages/rollup/test/integration/foo.js, but could not be resolved – treating it as an external dependency
I also don't understand this one, both why it only failed on CI (not locally) and why this change fixes it?
alexeagle
approved these changes
May 11, 2021
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.