fix(esbuild): 'output' is passed twice when used #2587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When passing 'output', esbuild throws
Error in esbuild: rule(...) got multiple values for parameter 'output'
Issue Number: N/A
What is the new behavior?
Fix esbuild_macro always passing the 'output' argument as generated by the rule's name even when the user provides their own 'output' argument.
Does this PR introduce a breaking change?
Other information
I think there may also be a bug with 'output_map' since as far as I can tell, esbuild doesn't let you specify the output file for the sourcemap and always bases it off of the output file's name. Perhaps it shouldn't be an argument to the rule.