Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): files not being found when building external repo #2563

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix(esbuild): files not being found when building external repo #2563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/esbuild/helpers.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,9 @@ def write_jsconfig_file(ctx, path_alias_mappings):
File object reference for the jsconfig file
"""

# The package path
rule_path = paths.dirname(ctx.build_file_path)
# The package path, including an "external/repo_name/" prefix if the package is in
# an external repo.
rule_path = paths.join(ctx.label.workspace_root, paths.dirname(ctx.build_file_path))

# Replace all segments in the path with .. join them with "/" and postfix
# it with another / to get a relative path from the build file dir
Expand Down