Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin): provide proper error if npm_package_bin has no outs #2557

Merged
merged 1 commit into from
Mar 26, 2021
Merged

fix(builtin): provide proper error if npm_package_bin has no outs #2557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/node/npm_package_bin.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _inputs(ctx):
def _impl(ctx):
if ctx.attr.output_dir and ctx.outputs.outs:
fail("Only one of output_dir and outs may be specified")
if not ctx.attr.output_dir and not ctx.outputs.outs and not ctx.attr.stdout:
if not ctx.attr.output_dir and not len(ctx.outputs.outs) and not ctx.attr.stdout:
fail("One of output_dir, outs or stdout must be specified")

args = ctx.actions.args()
Expand Down