feat: add generate_local_modules_build_files flag to yarn_install and npm_install rules #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
|
@alexeagle do you think we can get this fix in for the next minor? |
|
It depends if it's merged before then 😊 |
|
👍 I've kept the previous feature logic, just removed the current check to automatically determine if the feature should run (as it is not currently working as expected) and just used a variable to control it from the rule instead |
|
Solved the conflicts with the upstream |
…ocal-linked-modules-behind-flag
mattem
approved these changes
Feb 18, 2021
ljharb
reviewed
Feb 23, 2021
| When using a monorepo it's common to have modules that we want to use locally and | ||
| publish to an external package repository. This can be achieved using a `js_library` rule | ||
| with a `package_name` attribute defined inside the local package `BUILD` file. However, | ||
| if the project relies on the local package dependency with `file:` (npm) or `link:` (yarn) to be used outside Bazel, this |
There was a problem hiding this comment.
npm also supports link: and yarn also supports file:, so i'm not sure why these parentheticals are here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current expected behaviour was the one introduced by #2330
However there was a regression and after reanalysing it I believe we will be better served by hide that feature behind a flag other than try to proceed with it in an auto discoverable logic.
What is the new behavior?
With that new behaviour if you set
generate_local_modules_build_files=Falsein bothyarn_installornpm_installrules, BUILD files forsymlinked node_moduleswill be also symlinked instead of auto generated.Does this PR introduce a breaking change?
Other information