Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(concatjs_devserver): Updated io_bazel_rules_go dependency #2364

Conversation

KrauseStefan
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Using the old version

Issue Number: N/A

What is the new behavior?

Using the new version without the path

Does this PR introduce a breaking change?

  • Yes
  • No - Hope not

Other information

White debugging some other issue I updated this dependency thinking that might solve the problem, turns out it did not but instead of throwing the code away I will would ask if you where interested in this update

References
bazelbuild/bazel#12744
bazel-contrib/rules_go#2076

CC @alexeagle

@google-cla google-cla bot added the cla: yes label Dec 23, 2020
@KrauseStefan
Copy link
Contributor Author

Re created PR #2360 as it was closed when the 3.x branch was deleted

@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Mar 24, 2021
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

This PR was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant