Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace @bazel_tools//platforms with @platforms//os #2249

Closed
wants to merge 47 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
e72c145
fix(builtin): give a longer timeout for _create_build_files
Oct 17, 2020
6305db3
fix(typescript): don't include _valid_options marker file in outs
Oct 18, 2020
0a1e576
chore: allow node versions <= 14.14.0
mattem Oct 17, 2020
29901c3
chore: update rules_docker to 0.14.4
mattem Oct 17, 2020
8db9182
docs: minor update for readability and formatting (#2243)
evahowe Oct 20, 2020
1672968
Fix small typo in changelog
lencioni Oct 21, 2020
0c3bce6
chore(docs): move ts_library docs into ts_library
Oct 19, 2020
9a50cb6
chore(karma): remove dependency on tmp
Oct 27, 2020
12571ee
feat(typescript): add allow_js support to ts_project
Oct 29, 2020
700374a
fix(exmaples/nestjs): add module_name field in ts_library
lovepocky Oct 24, 2020
9ba4b9a
docs: fix a typo of angular-architect example (#2272)
JiaLiPassion Nov 8, 2020
2bff74d
chore: bump days before closing stale issues to 90
mattem Nov 8, 2020
0167236
Fix select with conditons on darwin.
comius Nov 9, 2020
19272ef
build: add 'fix-windows' tag due to windows flaky tests
mattem Nov 8, 2020
9663b85
feat(typescript): worker mode for ts_project (#2136)
mrmeku Nov 10, 2020
51de4e0
feat(node_repositories): Added auth option for downloading nodejs and…
KrauseStefan Oct 30, 2020
bc36519
fix: npm_package.pack should work in windows os
JiaLiPassion Oct 27, 2020
3c11800
feat(examples): adds example for running jest with typescript (#2245)
fredrikredflag Nov 10, 2020
86bef24
fix(typescript): specify rootDir as absolute path
jbedard Oct 6, 2020
a6e15ea
refactor: ts_project cleanup
Nov 10, 2020
1eeabbe
feat(cypress): remove browiserify preprocessor
Sep 22, 2020
39251fb
docs: update docs for release
Nov 10, 2020
70294f2
chore(release): 2.3.0
Nov 10, 2020
423ef73
chore: update lock files for release
Nov 10, 2020
76c3f51
fix: npm_package.pack on Windows should not generate undefined.tgz
JiaLiPassion Nov 11, 2020
799abf5
chore: update nodejs versions (#2284)
mattinsler Nov 16, 2020
185c632
perf(cypress): pack cypress runfiles into a single tar
Nov 17, 2020
681c668
chore: add GitHub Workflow to update NodeJS versions every night
Nov 13, 2020
311894c
chore: fix a link
jyane Nov 24, 2020
11ce24c
chore: fix the link again
Nov 24, 2020
8adebda
fix(builtin): make linker deterministic when resolving from manifest …
gregmagolan Nov 24, 2020
d1765d6
chore: re-lock jest dependencies
Nov 24, 2020
3928f13
chore(release): 2.3.1
Nov 24, 2020
a6977f6
chore: update lock files for release
Nov 24, 2020
cfdf257
chore: update dependency com_google_protobuf to v3.14.0
renovate-bot Nov 25, 2020
5194aec
chore: update dependency bazel_toolchains to v3.7.0
renovate-bot Nov 25, 2020
44f8d12
fix launcher script terminating before child terminates on SIGTERM
Schibum Nov 25, 2020
8e76536
chore: update dependency bazel_toolchains to v3.7.1
renovate-bot Nov 26, 2020
cc04f6c
fix(examples): fix jest example on windows
Sep 8, 2020
c344401
fix(builtin): give better error when linker runs on Node <10
Nov 30, 2020
e09c55a
docs(typescript): link some user-contributed doc (#2322)
alexeagle Dec 3, 2020
59ae65f
chore: allow node versions >=12 <=14 (#2332)
mistic Dec 5, 2020
c148138
chore: update rules_proto commit hash to 84ba6ec (#2334)
renovate-bot Dec 8, 2020
85dc132
fix(builtin): add DeclarationInfo sources from dependencies as inputs…
mattem Dec 16, 2020
364ac89
feat: allow running NPM tools from execroot (#2297)
duarten Dec 18, 2020
31c4683
chore: update to bazel 3.6 (#2230)
alexeagle Dec 18, 2020
652e383
chore: enable incompatible_use_platforms_repo_for_constraints for exa…
Oct 22, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
bazel: 3.0.0
bazel: 3.6.0
tasks:
ubuntu1604:
name: ubuntu1604
Expand Down Expand Up @@ -462,7 +462,7 @@ tasks:
build_flags:
# TODO(gregmagolan): figure out how to install missing shared libs
# Without this filter the @cypress external repository will be built and that build will fail due to missing shared libs.
- "--build_tag_filters=-cypress"
- "--build_tag_filters=-cypress,-pkg_npm.pack"
test_flags:
# TODO(gregmagolan): figure out how to install missing shared libs
- "--test_arg=-cypress"
9 changes: 4 additions & 5 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import %workspace%/common.bazelrc
# This lets us glob() up all the files inside the examples to make them inputs to tests
# To update these lines, just run `yarn bazel:update-deleted-packages`
# (Note, we cannot use common --deleted_packages because the bazel version command doesn't support it)
build --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/home,examples/angular/src/app/hello-world,examples/angular/src/app,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/shared/material,examples/angular/src/lib/shorten,examples/angular/src,examples/angular/src/assets,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/lib/typography,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/src,examples/angular_view_engine/src/assets,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/cypress,examples/from_source,examples/jest,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node,examples/vendored_node_and_yarn,examples/vue,examples/vue/src,examples/web_testing,examples/webapp,examples/worker,e2e/bazel_managed_deps,e2e/coverage,e2e/coverage/node_modules/@bazel/typescript/internal/devserver,e2e/coverage/node_modules/@bazel/typescript/internal,e2e/coverage/node_modules/@bazel/typescript/devserver,e2e/coverage/node_modules/@bazel/typescript/third_party/github.com/bazelbuild/bazel/src/main/protobuf,e2e/coverage/node_modules/@bazel/typescript/third_party/npm/requirejs,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp
query --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/home,examples/angular/src/app/hello-world,examples/angular/src/app,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/shared/material,examples/angular/src/lib/shorten,examples/angular/src,examples/angular/src/assets,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/lib/typography,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/src,examples/angular_view_engine/src/assets,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/cypress,examples/from_source,examples/jest,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node,examples/vendored_node_and_yarn,examples/vue,examples/vue/src,examples/web_testing,examples/webapp,examples/worker,e2e/bazel_managed_deps,e2e/coverage,e2e/coverage/node_modules/@bazel/typescript/internal/devserver,e2e/coverage/node_modules/@bazel/typescript/internal,e2e/coverage/node_modules/@bazel/typescript/devserver,e2e/coverage/node_modules/@bazel/typescript/third_party/github.com/bazelbuild/bazel/src/main/protobuf,e2e/coverage/node_modules/@bazel/typescript/third_party/npm/requirejs,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp
build --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/home,examples/angular/src/app/hello-world,examples/angular/src/app,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/shared/material,examples/angular/src/lib/shorten,examples/angular/src,examples/angular/src/assets,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/lib/typography,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/src,examples/angular_view_engine/src/assets,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/cypress,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node,examples/vendored_node_and_yarn,examples/vue,examples/vue/src,examples/web_testing,examples/webapp,examples/worker,e2e/bazel_managed_deps,e2e/coverage,e2e/coverage/node_modules/@bazel/typescript/internal/devserver,e2e/coverage/node_modules/@bazel/typescript/internal,e2e/coverage/node_modules/@bazel/typescript/devserver,e2e/coverage/node_modules/@bazel/typescript/third_party/github.com/bazelbuild/bazel/src/main/protobuf,e2e/coverage/node_modules/@bazel/typescript/third_party/npm/requirejs,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp
query --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/home,examples/angular/src/app/hello-world,examples/angular/src/app,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/shared/material,examples/angular/src/lib/shorten,examples/angular/src,examples/angular/src/assets,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/lib/typography,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/src,examples/angular_view_engine/src/assets,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/cypress,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node,examples/vendored_node_and_yarn,examples/vue,examples/vue/src,examples/web_testing,examples/webapp,examples/worker,e2e/bazel_managed_deps,e2e/coverage,e2e/coverage/node_modules/@bazel/typescript/internal/devserver,e2e/coverage/node_modules/@bazel/typescript/internal,e2e/coverage/node_modules/@bazel/typescript/devserver,e2e/coverage/node_modules/@bazel/typescript/third_party/github.com/bazelbuild/bazel/src/main/protobuf,e2e/coverage/node_modules/@bazel/typescript/third_party/npm/requirejs,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp

# Mock versioning command to test the --stamp behavior
build --workspace_status_command="echo BUILD_SCM_VERSION 1.2.3"
Expand Down Expand Up @@ -49,6 +49,5 @@ build:docker-sandbox --experimental_enable_docker_sandbox
# This is the same image used on BazelCI rbe_ubuntu1604 job
build:docker-sandbox --experimental_docker_image=gcr.io/cloud-marketplace/google/rbe-ubuntu16-04

# Incompatible flags to run with
build --incompatible_no_implicit_file_export
build --incompatible_restrict_string_escapes
# We have to turn this off for now because not all dependencies comply with this
build --noincompatible_use_platforms_repo_for_constraints
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.0
3.6.0
6 changes: 3 additions & 3 deletions .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}

# The number of days old an issue can be before marking it stale.
days-before-stale: 60
days-before-stale: 90
# Number of days of inactivity before a stale issue is closed
days-before-close: 14

Expand All @@ -30,14 +30,14 @@ jobs:

stale-issue-message: >
This issue has been automatically marked as stale because it has not had
any activity for 60 days.
any activity for 90 days.
It will be closed if no further activity occurs in two weeks.
Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely.
Thanks for your contributions to rules_nodejs!

stale-pr-message: >
This Pull Request has been automatically marked as stale because it has not had
any activity for 60 days.
any activity for 90 days.
It will be closed if no further activity occurs in two weeks.
Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely.
Thanks for your contributions to rules_nodejs!
Expand Down
37 changes: 37 additions & 0 deletions .github/workflows/update-nodejs-versions.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# See https://github.com/marketplace/actions/github-action-for-yarn

name: Update NodeJS Versions

on:
schedule:
# run at 01:30 UTC daily
- cron: "30 1 * * *"

jobs:
updateNodejsVersions:
runs-on: ubuntu-latest

steps:
- name: Git Checkout
uses: actions/checkout@v2
with:
fetch-depth:

- name: Run yarn update-nodejs-versions
uses: borales/[email protected]
with:
cmd: update-nodejs-versions

- name: Create Pull Request
uses: peter-evans/create-pull-request@v3
with:
token: ${{ secrets.PAT }}
commit-message: Update NodeJS Versions
title: Update NodeJS Versions
body: |
- Updated NodeJS Versions using `yarn update-nodejs-versions`

Auto-generated by [create-pull-request][1]

[1]: https://github.com/peter-evans/create-pull-request
branch: update-nodejs-versions
39 changes: 38 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,40 @@
## [2.3.1](https://github.com/bazelbuild/rules_nodejs/compare/2.3.0...2.3.1) (2020-11-24)


### Bug Fixes

* **builtin:** make linker deterministic when resolving from manifest & fix link_workspace_root with no runfiles ([8adebda](https://github.com/bazelbuild/rules_nodejs/commit/8adebda))
* npm_package.pack on Windows should not generate undefined.tgz ([76c3f51](https://github.com/bazelbuild/rules_nodejs/commit/76c3f51))


### Performance Improvements

* **cypress:** pack cypress runfiles into a single tar ([185c632](https://github.com/bazelbuild/rules_nodejs/commit/185c632))



# [2.3.0](https://github.com/bazelbuild/rules_nodejs/compare/2.2.2...2.3.0) (2020-11-10)


### Bug Fixes

* **typescript:** specify rootDir as absolute path ([86bef24](https://github.com/bazelbuild/rules_nodejs/commit/86bef24))
* npm_package.pack should work in windows os ([bc36519](https://github.com/bazelbuild/rules_nodejs/commit/bc36519))
* **builtin:** give a longer timeout for _create_build_files ([e72c145](https://github.com/bazelbuild/rules_nodejs/commit/e72c145)), closes [#2231](https://github.com/bazelbuild/rules_nodejs/issues/2231)
* **exmaples/nestjs:** add module_name field in ts_library ([700374a](https://github.com/bazelbuild/rules_nodejs/commit/700374a))
* **typescript:** don't include _valid_options marker file in outs ([6305db3](https://github.com/bazelbuild/rules_nodejs/commit/6305db3)), closes [#2078](https://github.com/bazelbuild/rules_nodejs/issues/2078)


### Features

* **cypress:** remove browiserify preprocessor ([1eeabbe](https://github.com/bazelbuild/rules_nodejs/commit/1eeabbe))
* **examples:** adds example for running jest with typescript ([#2245](https://github.com/bazelbuild/rules_nodejs/issues/2245)) ([3c11800](https://github.com/bazelbuild/rules_nodejs/commit/3c11800))
* **node_repositories:** Added auth option for downloading nodejs and yarn ([51de4e0](https://github.com/bazelbuild/rules_nodejs/commit/51de4e0))
* **typescript:** add allow_js support to ts_project ([12571ee](https://github.com/bazelbuild/rules_nodejs/commit/12571ee))
* **typescript:** worker mode for ts_project ([#2136](https://github.com/bazelbuild/rules_nodejs/issues/2136)) ([9663b85](https://github.com/bazelbuild/rules_nodejs/commit/9663b85))



## [2.2.2](https://github.com/bazelbuild/rules_nodejs/compare/2.2.1...2.2.2) (2020-10-17)


Expand All @@ -7,7 +44,7 @@
* **example:** remove compression dependencies ([75bf720](https://github.com/bazelbuild/rules_nodejs/commit/75bf720))
* **example:** remove index.html from prodapp srcs ([c7be89b](https://github.com/bazelbuild/rules_nodejs/commit/c7be89b))
* **example:** remove server side compression ([6d5aafb](https://github.com/bazelbuild/rules_nodejs/commit/6d5aafb))
* **exmaple:** add docstring to ngsw_config rule ([481fa21](https://github.com/bazelbuild/rules_nodejs/commit/481fa21))
* **example:** add docstring to ngsw_config rule ([481fa21](https://github.com/bazelbuild/rules_nodejs/commit/481fa21))


### Features
Expand Down
7 changes: 4 additions & 3 deletions DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ Check if there are any breaking changes since the last tag - if so, this will be
1. Manually update the CHANGELOG.md based on the commits since the last release. Look for breaking changes that weren't documented.
1. If publishing from inside Google, set NPM_REGISTRY="--registry https://wombat-dressing-room.appspot.com" in your environment
1. Build npm packages and publish them: `./scripts/publish_release.sh`
1. Run `./scripts/update_nested_lock_files.sh` to update the lock files in all nested workspaces to new release
1. `git commit -a -m 'chore: update lock files for release'`
1. `git push upstream && git push upstream --tags`
1. (Manual for now): go to the [releases] page, edit the release with rough changelog (especially note any breaking changes!) and upload the release artifact from `rules_nodejs-[version].tar.gz`. Also copy the release notes from CHANGELOG.md
1. Announce the release on Angular slack in `#tools-abc-discuss`
1. Announce the release on Bazel slack in `#javascript`
1. Run `yarn stardoc` again so the new release http_archive gets updated in the .html copy of install.md
1. Run `./scripts/update_nested_lock_files.sh` to update the lock files in all nested workspaces to new release
1. `git commit -a -m 'chore: update lock files for release'; git push upstream`

[releases]: https://github.com/bazelbuild/rules_nodejs/releases
4 changes: 3 additions & 1 deletion common.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ build --nolegacy_external_runfiles
# when running bazel via `yarn bazel`.
# See https://github.com/angular/angular/issues/27514.
build --incompatible_strict_action_env
run --incompatible_strict_action_env
build --incompatible_no_implicit_file_export
build --incompatible_restrict_string_escapes
build --incompatible_use_platforms_repo_for_constraints

# When running `bazel coverage` --instrument_test_targets needs to be set in order to
# collect coverage information from test targets
Expand Down
Loading