Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin): use posix paths in assembler #1636

Merged
merged 1 commit into from
Feb 13, 2020
Merged

fix(builtin): use posix paths in assembler #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/pkg_web/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ nodejs_binary(
jasmine_node_test(
name = "assembler_test",
srcs = ["assembler_spec.js"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, we already had the test coverage for this bug too? :(
We ought to take a pass over all the fix-windows tagged targets...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that’s a good idea. I was also surprised to see that there was coverage.

tags = [
"fix-windows",
],
deps = [
"assembler.js",
],
Expand Down
3 changes: 2 additions & 1 deletion internal/pkg_web/assembler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ function main(params) {
function copy(f) {
if (fs.statSync(f).isDirectory()) {
for (const file of fs.readdirSync(f)) {
copy(path.join(f, file));
// Change paths to posix
copy(path.join(f, file).replace(/\\/g, '/'));
}
} else {
const dest = path.join(outdir, relative(f));
Expand Down