-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add protractor angular architect #1594
feat(examples): add protractor angular architect #1594
Conversation
be34cca
to
e51a0b9
Compare
failing in circleci with
Not sure what version is installed in circleci |
Chrome version is whatever comes with circleci/node:10.16-browsers. You could try updating the images to |
Newest images will probably have Chrome 79 or 80. |
e51a0b9
to
4a473c8
Compare
Awesome, that did it! |
Cleanup and comment on protractor Chrome args in e2e test
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Adds required target and configuration to make protractor on the Angular Bazel Architect example work under bazel.