Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add protractor angular architect #1594

Merged

Conversation

Toxicable
Copy link

Adds required target and configuration to make protractor on the Angular Bazel Architect example work under bazel.

@Toxicable Toxicable force-pushed the examples/angular-architect-e2e branch 2 times, most recently from be34cca to e51a0b9 Compare January 31, 2020 19:39
@Toxicable
Copy link
Author

failing in circleci with

[19:55:18] E/launcher - session not created: This version of ChromeDriver only supports Chrome version 79

Not sure what version is installed in circleci

@gregmagolan
Copy link
Collaborator

Chrome version is whatever comes with circleci/node:10.16-browsers.

You could try updating the images to circleci/node:12.14-browsers && circleci/node:12.14. We don't rely on the version of node from the images since node_repositories handles download node for bazel

@gregmagolan
Copy link
Collaborator

Newest images will probably have Chrome 79 or 80.

@Toxicable Toxicable force-pushed the examples/angular-architect-e2e branch from e51a0b9 to 4a473c8 Compare February 1, 2020 00:10
@Toxicable
Copy link
Author

Awesome, that did it!

Cleanup and comment on protractor Chrome args in e2e test
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 5, 2020
@gregmagolan
Copy link
Collaborator

@googlebot I consent

@gregmagolan
Copy link
Collaborator

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Feb 5, 2020
@gregmagolan gregmagolan self-requested a review February 5, 2020 06:13
@gregmagolan gregmagolan merged commit d420019 into bazel-contrib:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants