fix: unset YARN_IGNORE_PATH before calling yarn in @nodejs targets #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
gregmagolan
changed the title
Same as bazel-contrib#1588 but for the @nodejs//:yarn && @nodejs//:yarn_node_repositories targets. Unset YARN_IGNORE_PATH before calling yarn incase it is set so that .yarnrc yarn-path is followed if set. This is for the case when calling bazel from yarn with `yarn bazel …` and yarn follows yarn-path in .yarnrc it will set YARN_IGNORE_PATH=1 which will prevent the bazel call into yarn from also following the yarn-path as desired.
gregmagolan
force-pushed
the
yarn-path-fixes
branch
from
061c9aa to
24d3b9e
Compare
alexeagle
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1588 but for the @nodejs//:yarn && @nodejs//:yarn_node_repositories targets.
Unset YARN_IGNORE_PATH before calling yarn incase it is set so that
.yarnrc yarn-path is followed if set. This is for the case when calling
bazel from yarn with
yarn bazel ...and yarn follows yarn-path in.yarnrc it will set YARN_IGNORE_PATH=1 which will prevent the bazel
call into yarn from also following the yarn-path as desired.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information