Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bazelbuild/rules_nodejs#1567 Recursively copy files from subdir… #1586

Conversation

joeljeske
Copy link
Contributor

…ectories into mirrored structure in the npm archive.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

I don't think there are any relevant documentation updates for this fix. I think it was the expected behavior.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1567

What is the new behavior?

Directories can be copied into a mirror structure inside the npm archive. Presumably these directories would be created using the declare_directory action.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…nto mirrored structure in the npm archive.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@joeljeske
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!

@@ -51,4 +51,7 @@ describe('pkg_npm srcs', () => {
// TODO(alexeagle): there isn't a way to test this yet, because the pkg_npm under test
// has to live in the root of the repository in order for external/foo to appear inside it
});
it('copies entire contents of directories',
() => {expect(read('rollup/bundle/subdirectory/index.js'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super job adding tests 🎉

@alexeagle alexeagle merged commit c83b026 into bazel-contrib:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants