Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix typo in TypeScript.md #1211

Merged
merged 2 commits into from
Oct 2, 2019
Merged

fix(docs): fix typo in TypeScript.md #1211

merged 2 commits into from
Oct 2, 2019

Conversation

pshields
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alexeagle
Copy link
Collaborator

Thank you Mario, but our princess is in another castle.

This file is generated from something else, could you find that and update also?

@alexeagle
Copy link
Collaborator

@pshields
Copy link
Contributor Author

pshields commented Oct 1, 2019

Thanks, Alex! Done.

@alexeagle alexeagle merged commit 893f61e into bazel-contrib:master Oct 2, 2019
Toxicable pushed a commit to Toxicable/rules_nodejs that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants