Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(README): update "sections below" reference #1210

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix(README): update "sections below" reference #1210

merged 1 commit into from
Oct 3, 2019

Conversation

pshields
Copy link
Contributor

This PR updates the "sections below" reference to point to the installation docs, since the details and alternatives are not present in the sections below of the README.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The documentation refers to "sections below", but the sections below do not contain additional details or alternatives for installing rules_nodejs.

Issue Number: N/A

What is the new behavior?

Link to the docs page that contains the additional details and alternatives.

Does this PR introduce a breaking change?

  • Yes
  • No

This PR updates the "sections below" reference to point to the installation docs, since the details and alternatives are not present in the sections below of the README.
@alexeagle alexeagle merged commit a59203c into bazel-contrib:master Oct 3, 2019
Toxicable pushed a commit to Toxicable/rules_nodejs that referenced this pull request Oct 12, 2019
This PR updates the "sections below" reference to point to the installation docs, since the details and alternatives are not present in the sections below of the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants