Terser/worker threads #1172
Closed
Terser/worker threads #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2019 14:02
Using a pool of worker threads we'll get better performance when compressing multiple files at the same time, since we avoid the overhead of starting new processes and we can reused previously spawened threads
Toxicable
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
12 tasks
|
still working on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
@bazel/terseruseschild_processfor it's workersIssue Number: #1177
What is the new behavior?
When a directory is passed as input,
worker_threads are spin up as the workers instead of child processes.Does this PR introduce a breaking change?
Other information