fix(builtin): linker test should run program as an action #1113
Conversation
alexeagle
force-pushed
the
linker
branch
2 times, most recently
from
e8d3fa8 to
a49e739
Compare
alexeagle
force-pushed
the
linker
branch
12 times, most recently
from
3e186e2 to
9cb8218
Compare
We were accidentally using runfiles resolution to read all user inputs, because we ran as an sh_test
| # However, we still want to be able to write our tooling in TypeScript. | ||
| # This macro lets us check in the resulting .js files, and still ensure that they are | ||
| # compiled from the .ts by using a golden file test. | ||
| def checked_in_ts_library(name, checked_in_js, **kwargs): |
There was a problem hiding this comment.
what ends up copying the output of the ts_library here to the check_in_js file? maybe I'm just not seeing it?
There was a problem hiding this comment.
it's the golden_file_test below
| // Use junction on Windows since symlinks require elevated permissions. | ||
| // We only link to directories so junctions work for us. | ||
| fs.symlinkSync(target, path, 'junction'); | ||
| if (VERBOSE_LOGS) { |
There was a problem hiding this comment.
maybe if (VERBOSE_LOGS || DEBUG) so if you set DEBUG env you're checking for this? Maybe throw in that case as well since seems like failure you should find out about if you set DEBUG?
There was a problem hiding this comment.
I didn't want to throw because I think it's probably wrong for the program to have different behavior when you turn on VERBOSE_LOGS - seems like we want a strict mode in general which is maybe different from how much logging we do
There was a problem hiding this comment.
I was thinking just throw if DEBUG was set not on VERBOSE_LOGS. Program can have different behaviors with DEBUG.
There was a problem hiding this comment.
But maybe a strict mode would make more sense instead of overloading the DEBUG semantics
We were accidentally using runfiles resolution to read all user inputs, because we ran as an sh_test