Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error using Jasmine 4.0 and jasmine_node_test #3289

Closed
jstuder-gh opened this issue Jan 26, 2022 · 0 comments · Fixed by #3283
Closed

Error using Jasmine 4.0 and jasmine_node_test #3289

jstuder-gh opened this issue Jan 26, 2022 · 0 comments · Fixed by #3283
Labels
bug

Comments

@jstuder-gh
Copy link
Contributor

🐞 bug report

Affected Rule

jasmine_node_test

Is this a regression?

No

Description

When using Jasmine 4.0 there is an error when executing jasmine_runner.js. The runner script is using the onComplete method which has been removed in 4.0. In addition the jasmine.Spec and jasmine.Suite identifiers used when gathering Specs for sharding are no longer accessible.

🔬 Minimal Reproduction

Upgrade jasmine and jasmine-core packages to 4.0.0. Then run jasmine tests.

bazelisk test //packages/jasmine/...

🔥 Exception or Error


INFO: From Testing //packages/jasmine/test:generated_require_spec_test:
==================== Test output for //packages/jasmine/test:generated_require_spec_test:
[jasmine_runner.js] An error has been reported: TypeError: jrunner.onComplete is not a function
    at main (packages/jasmine/jasmine_runner.js:119:11)
    at packages/jasmine/jasmine_runner.js:182:32
    at Object. (packages/jasmine/jasmine_runner.js:187:5)
    at Module._compile (node:internal/modules/cjs/loader:1095:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1124:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:816:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
    at node:internal/main/run_main_module:17:47

🌍 Your Environment

Operating System:

  
  Linux x86_64

Output of bazel version:

  
  5.0.0

Rules_nodejs version:

  
  5.0.1
@jstuder-gh jstuder-gh mentioned this issue Jan 26, 2022
Closed
10 tasks
@alan-agius4 alan-agius4 linked a pull request Jan 26, 2022 that will close this issue
fix(jasmine): replace deprecated Jasmine APIs that have been removed in version 4 #3283
Merged
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
5baea0a 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
287cbd7 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
2d346de 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
84cd5ce 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
54a1d03 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
b3ef167 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
1a91fe7 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
268acc5 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
315c7d1 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
2c63fa8 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
e263803 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alan-agius4 added a commit to alan-agius4/rules_nodejs that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
80f6d55 
…in version 4

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes bazel-contrib#3289
alexeagle pushed a commit that referenced this issue Jan 26, 2022
@alan-agius4
fix(jasmine): replace deprecated Jasmine APIs that have been removed …
bde750b 
…in version 4 (#3283)

With this change we replace APIs that have been deprecated in version 4 and removed in version 4

```
Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method.
```

Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.

Closes #3289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@jstuder-gh @alan-agius4