npm_install runs three times on a clean build

[alexeagle]

We run npm_install three times. For a client I'm working with, this makes a 75sec npm install operation require almost 250sec just to bazel query @npm//:all 😱

Repro

Run any npm_install repo rule, such as

t=$(mktemp -d); bazel --output_base=$t build @npm_node_patches//:all; echo "output_base $t"

and then look at the $t/command.profile.gz in chrome://tracing

and see horrifying result

[alexeagle]

https://github.com/bazelbuild/bazel/blob/4.0.0/src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryFunction.java#L184-L196 provides the clue

Even resolving a Label() constructor causes a repo rule to restart. TWICE