Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named ts_projects for bazel output progress messages #1927

Closed
joeljeske opened this issue May 29, 2020 · 2 comments · Fixed by #1944
Closed

Support named ts_projects for bazel output progress messages #1927

joeljeske opened this issue May 29, 2020 · 2 comments · Fixed by #1944

Comments

@joeljeske
Copy link
Contributor

joeljeske commented May 29, 2020

🚀 feature request

Relevant Rules

ts_project

Description

I am using a single tsconfig.json for most of my packages. I only include the relevant srcs/deps for each package but leverage the same tsconfig.json file. The bazel output log shows progress like this:

Compiling TypeScript project path/to/tsconfig.json
Compiling TypeScript project path/to/tsconfig.json
Compiling TypeScript project path/to/tsconfig.json
Compiling TypeScript project path/to/tsconfig.json
Compiling TypeScript project path/to/tsconfig.json

(Those are all separate target messages)

Describe the solution you'd like

I would like the progress message to be customizable, or at least use the target in the name instead of the tsconfig name.

Describe alternatives you've considered

Patching @bazel/typescript for this behavior.

Perhaps I am using ts_project incorrectly by re-using the same config, but it otherwise seems to work find.

@alexeagle
Copy link
Collaborator

Yeah you're holding it right. Having a single config file is a good practice.

You can see other progress_message around the repo, they are not super consistent. I did do a pass once to make them more consistent though, so I'd propose

"Compiling TypeScript project %s [tsc -p %s]" % (ctx.label, ctx.file.tsconfig.short_path)
WDYT?

@joeljeske
Copy link
Contributor Author

Looks fine to me, just making sure you can see a label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants