Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation for @bazel/hide-build-files package #1613

Closed
1 of 5 tasks
alexeagle opened this issue Feb 6, 2020 · 1 comment · Fixed by #1757
Closed
1 of 5 tasks

Deprecation for @bazel/hide-build-files package #1613

alexeagle opened this issue Feb 6, 2020 · 1 comment · Fixed by #1757
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone
2.0

Comments

@alexeagle
Copy link
Collaborator

alexeagle commented Feb 6, 2020 •
edited
Loading

Bazel 2.1 supports .bazelignore files in external repos (thanks @meteorcloudy !)
Our workaround for this can now be deprecated.

I just merged a change which removes our own dependency on it (82599e6)

Next steps:
@alexeagle alexeagle added the cleanup Tech debt, resolving it improves our own velocity label Feb 6, 2020
@gregmagolan gregmagolan added this to the 2.0 milestone Feb 6, 2020
@KrauseStefan
Copy link
Contributor

#1632 is related to this

alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 29, 2020
@alexeagle
chore: remove hide-build-files functionality
bf5a757 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require *their* users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater. Also the hide_bazel_files attribute was removed from pkg_npm, yarn_install, and npm_install.

Fixes bazel-contrib#1613
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 29, 2020
@alexeagle
chore: remove hide-build-files functionality
c028361 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require *their* users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.
Also the hide_build_files attribute was removed from pkg_npm, and always_hide_bazel_files was removed from yarn_install and npm_install.

Fixes bazel-contrib#1613
@alexeagle alexeagle mentioned this issue Mar 29, 2020
Merged
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 29, 2020
@alexeagle
chore: remove hide-build-files functionality
b706351 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require *their* users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.
Also the hide_build_files attribute was removed from pkg_npm, and always_hide_bazel_files was removed from yarn_install and npm_install.

Fixes bazel-contrib#1613
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 29, 2020
@alexeagle
chore: remove hide-build-files functionality
db8d9a8 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require *their* users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.
Also the hide_build_files attribute was removed from pkg_npm, and always_hide_bazel_files was removed from yarn_install and npm_install.

Fixes bazel-contrib#1613
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Mar 30, 2020
@alexeagle
chore: remove hide-build-files functionality
95a43e2 
BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.

We write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

Fixes bazel-contrib#1613
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Apr 12, 2020
@alexeagle
chore: remove hide-build-files functionality
ef3a12d 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require *their* users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.
Also the hide_build_files attribute was removed from pkg_npm, and always_hide_bazel_files was removed from yarn_install and npm_install.
These attributes are no longer needed because they were a workaround for older versions of Bazel.

Fixes bazel-contrib#1613
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Apr 13, 2020
@alexeagle
chore: remove hide-build-files package
1f5d62f 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require their users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

We leave support for legacy packages which were publishing with _BUILD files.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.
Also the hide_build_files attribute was removed from pkg_npm, and always_hide_bazel_files was removed from yarn_install and npm_install. These are no longer needed since 1.3.0

Fixes bazel-contrib#1613
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue May 3, 2020
@alexeagle
chore: remove hide-build-files package
f8e796b 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require their users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

We leave support for legacy packages which were publishing with _BUILD files.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.
Also the hide_build_files attribute was removed from pkg_npm, and always_hide_bazel_files was removed from yarn_install and npm_install. These are no longer needed since 1.3.0

Fixes bazel-contrib#1613
alexeagle added a commit that referenced this issue May 3, 2020
@alexeagle
chore: remove hide-build-files package
5d1d006 
Since 1.3.0, we write a .bazelignore file into the generated workspaces, so Bazel does not see BUILD files.
The features to hide the BUILD files are no longer needed.

We also stop hiding the BUILD files in packages published by pkg_npm. This means that users who publish packages built by that rule will now require their users to have rules_nodejs 1.3.0 or greater, which adds the .bazelignore file.

We leave support for legacy packages which were publishing with _BUILD files.

BREAKING CHANGE:
rules_nodejs now requires Bazel 2.1 or greater.
Also the hide_build_files attribute was removed from pkg_npm, and always_hide_bazel_files was removed from yarn_install and npm_install. These are no longer needed since 1.3.0

Fixes #1613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

chore: remove hide-build-files functionality alexeagle/rules_nodejs
3 participants
@alexeagle @gregmagolan @KrauseStefan