chore(6.0): remove typescript internals

.github/BUILD.bazel

@@ -8,10 +8,6 @@ generate_codeowners(
     # do not sort
     owners = [
         "//:OWNERS",
-        "//examples:OWNERS.examples_jest",
-        "//examples:OWNERS.examples_nestjs",
-        "//examples:OWNERS.examples_angular",
-        "//examples:OWNERS.examples_angular_bazel_architect",
     ],
 )
 

.github/CODEOWNERS

@@ -3,7 +3,3 @@
 #    yarn update-codeowners
 
 * @mattem @gregmagolan @alexeagle
-/examples/jest/** @mrmeku @alexeagle @gregmagolan @mattem
-/examples/nestjs/** @zachgrayio @zMotivat0r @rayman1104 @siberex @alexeagle @gregmagolan @mattem
-/examples/angular/** @alan-agius4 @jbedard @alexeagle @gregmagolan @mattem
-/examples/angular_bazel_architect/** @alan-agius4 @jbedard @alexeagle @gregmagolan @mattem

packages/typescript/checked_in_ts_project.bzl → internal/checked_in_tsc.bzl

@@ -1,23 +1,17 @@
-"checked_in_ts_project rule"
+"checked_in_tsc rule"
 
 load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
-load("//packages/typescript:index.bzl", "ts_project")
+load("//internal:tsc.bzl", "tsc")
 
-def checked_in_ts_project(name, src, checked_in_js = None, tsconfig = None, **kwargs):
-    """
-    In rules_nodejs "builtin" package, we are creating the toolchain for building
-    tsc-wrapped and executing ts_project, so we cannot depend on them.
-    However, we still want to be able to write our tooling in TypeScript.
-    This macro lets us check in the resulting .js files, and still ensure that they are
-    compiled from the .ts by using a golden file test.
-    """
+def checked_in_tsc(name, src, checked_in_js = None, tsconfig = None, **kwargs):
+    """A tsc rule that also asserts that the generated JS is up-to-date."""
     if not checked_in_js:
         checked_in_js = src[:-3] + ".js"
 
     if tsconfig == None:
         tsconfig = "//:tsconfig.json"
 
-    ts_project(
+    tsc(
         name = name,
         srcs = [src],
         tsconfig = tsconfig,

internal/coverage/BUILD.bazel

@@ -1,9 +1,9 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
 
 # BEGIN-INTERNAL
-load("//packages/typescript:checked_in_ts_project.bzl", "checked_in_ts_project")
+load("//internal:checked_in_tsc.bzl", "checked_in_tsc")
 
-checked_in_ts_project(
+checked_in_tsc(
     name = "lcov_merger_js_lib",
     src = "lcov_merger.ts",
     checked_in_js = "lcov_merger-js.js",

internal/linker/BUILD.bazel

@@ -2,14 +2,14 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 # BEGIN-INTERNAL
 load("//:index.bzl", "js_library")
-load("//packages/typescript:checked_in_ts_project.bzl", "checked_in_ts_project")
+load("//internal:checked_in_tsc.bzl", "checked_in_tsc")
 
 # We can't bootstrap the ts_library rule using the linker itself,
 # because the implementation of ts_library depends on the linker so that would be a cycle.
 # So we compile it to JS and check in the result as index.js.
 # To update index.js run:
 #   bazel run //internal/linker:linker_lib_check_compiled.update
-checked_in_ts_project(
+checked_in_tsc(
     name = "linker_lib",
     src = "link_node_modules.ts",
     checked_in_js = "index.js",

internal/linker/test/BUILD.bazel

@@ -1,6 +1,6 @@
-load("//packages/typescript:index.bzl", "ts_project")
+load("//internal:tsc.bzl", "tsc")
 
-ts_project(
+tsc(
     name = "test_lib",
     srcs = glob(["*.ts"]),
     deps = [

internal/linker/test/multi_linker/BUILD.bazel

@@ -1,6 +1,6 @@
-load("//packages/typescript:checked_in_ts_project.bzl", "checked_in_ts_project")
+load("//internal:checked_in_tsc.bzl", "checked_in_tsc")
 
-checked_in_ts_project(
+checked_in_tsc(
     name = "checked_in_test",
     src = "test.ts",
     checked_in_js = "checked_in_test.js",

internal/npm_install/BUILD.bazel

@@ -3,12 +3,12 @@ load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
 
 # BEGIN-INTERNAL
 # avoid leaking a ts dependency
-load("//packages/typescript:checked_in_ts_project.bzl", "checked_in_ts_project")
+load("//internal:checked_in_tsc.bzl", "checked_in_tsc")
 
 # Using checked in ts library like the linker
 # To update index.js run:
 #   bazel run //internal/npm_install:compile_generate_build_file_check_compiled.update
-checked_in_ts_project(
+checked_in_tsc(
     name = "compile_generate_build_file",
     src = "generate_build_file.ts",
     checked_in_js = "index.js",

internal/npm_install/npm_install.bzl

@@ -155,7 +155,7 @@ The above links will create the targets,
 @npm//target
 ```
 
-that can be referenced as `data` or `deps` by other rules such as `nodejs_binary` and `ts_project`
+that can be referenced as `data` or `deps` by other rules such as `nodejs_binary`
 and can be required as `@scope/target` and `target` with standard node_modules resolution at runtime,
 
 ```
@@ -168,16 +168,6 @@ nodejs_binary(
         "@npm//other/dep"
     ],
 )
-
-ts_project(
-    name = "test",
-    srcs = [...],
-    deps = [
-        "@npm//@scope/target",
-        "@npm//target"
-        "@npm//other/dep"
-    ],
-)
 ```
 """,
     ),

internal/pkg_npm/test/pkg_npm.spec.js

@@ -33,7 +33,7 @@ describe('pkg_npm', () => {
   it('copies files from other packages', () => {
     expect(readFromPkg('dependent_file')).toEqual('dependent_file content');
   });
-  it('copies js files from ts_project', () => {
+  it('copies js files from tsc', () => {
     expect(readFromPkg('foo.js')).toContain('exports.a = \'\';');
   });
   it('copies data dependencies', () => {

packages/typescript/index.bzl → internal/tsc.bzl

@@ -1,10 +1,10 @@
-load("@npm//typescript:index.bzl", "tsc")
+load("@npm//typescript:index.bzl", _tsc = "tsc")
 
-# Basic wrapper around tsc to replace ts_project()
-def ts_project(name, srcs, deps = [], data = [], tsconfig = "//:tsconfig.json", **kwargs):
+# Basic wrapper around tsc to replace tsc()
+def tsc(name, srcs, deps = [], data = [], tsconfig = "//:tsconfig.json", **kwargs):
     outs = [s.replace(".ts", ".js") for s in srcs] + [s.replace(".ts", ".d.ts") for s in srcs]
 
-    tsc(
+    _tsc(
         name = name,
         args = [
             "-p",

nodejs/private/BUILD.bazel

@@ -1,7 +1,5 @@
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
-exports_files(["ts_project_options_validator.js"])
-
 filegroup(
     name = "package_contents",
     srcs = glob(["*"]) + [