Skip to content

Commit

Permalink
chore(6.0): remove jasmine package
Browse files Browse the repository at this point in the history
It has been unmaintained for a year and has been replaced by https://github.com/aspect-build/rules_jasmine/.
  • Loading branch information
jbedard authored and alexeagle committed Apr 1, 2023
1 parent 16ba4ad commit e22631f
Show file tree
Hide file tree
Showing 112 changed files with 7 additions and 4,898 deletions.
4 changes: 2 additions & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import %workspace%/common.bazelrc
# This lets us glob() up all the files inside the examples to make them inputs to tests
# To update these lines, just run `yarn bazel:update-deleted-packages`
# (Note, we cannot use common --deleted_packages because the bazel version command doesn't support it)
build --deleted_packages=e2e/bazel_managed_deps,e2e/bazel_run_chdir,e2e/bazel_run_chdir/subfolder,e2e/coverage,e2e/fine_grained_symlinks,e2e/jasmine,e2e/linker_disabled_regression,e2e/linker_disabled_regression/subdir,e2e/node_loader_preserve_symlinks,e2e/nodejs_host,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/webapp,examples/angular,examples/angular/src,examples/angular/src/app,examples/angular/src/app/hello-world,examples/angular/src/app/home,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/assets,examples/angular/src/lib/shorten,examples/angular/src/shared/material,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protobufjs,examples/react_webpack,examples/toolchain,examples/vendored_node_and_yarn,examples/vendored_node_and_yarn/toolchains,examples/vue,examples/vue/src,examples/vue/src/components/HelloWorld,examples/web_testing,examples/webapp,examples/worker
query --deleted_packages=e2e/bazel_managed_deps,e2e/bazel_run_chdir,e2e/bazel_run_chdir/subfolder,e2e/coverage,e2e/fine_grained_symlinks,e2e/jasmine,e2e/linker_disabled_regression,e2e/linker_disabled_regression/subdir,e2e/node_loader_preserve_symlinks,e2e/nodejs_host,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/webapp,examples/angular,examples/angular/src,examples/angular/src/app,examples/angular/src/app/hello-world,examples/angular/src/app/home,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/assets,examples/angular/src/lib/shorten,examples/angular/src/shared/material,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protobufjs,examples/react_webpack,examples/toolchain,examples/vendored_node_and_yarn,examples/vendored_node_and_yarn/toolchains,examples/vue,examples/vue/src,examples/vue/src/components/HelloWorld,examples/web_testing,examples/webapp,examples/worker
build --deleted_packages=e2e/bazel_run_chdir,e2e/bazel_run_chdir/subfolder,e2e/fine_grained_symlinks,e2e/linker_disabled_regression,e2e/linker_disabled_regression/subdir,e2e/node_loader_preserve_symlinks,e2e/nodejs_host,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/webapp,examples/angular,examples/angular/src,examples/angular/src/app,examples/angular/src/app/hello-world,examples/angular/src/app/home,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/assets,examples/angular/src/lib/shorten,examples/angular/src/shared/material,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protobufjs,examples/react_webpack,examples/toolchain,examples/vue,examples/vue/src,examples/vue/src/components/HelloWorld,examples/web_testing,examples/webapp,examples/worker
query --deleted_packages=e2e/bazel_run_chdir,e2e/bazel_run_chdir/subfolder,e2e/fine_grained_symlinks,e2e/linker_disabled_regression,e2e/linker_disabled_regression/subdir,e2e/node_loader_preserve_symlinks,e2e/nodejs_host,e2e/nodejs_image,e2e/nodejs_image/foolib,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/webapp,examples/angular,examples/angular/src,examples/angular/src/app,examples/angular/src/app/hello-world,examples/angular/src/app/home,examples/angular/src/app/todos,examples/angular/src/app/todos/reducers,examples/angular/src/assets,examples/angular/src/lib/shorten,examples/angular/src/shared/material,examples/angular/tools,examples/angular_bazel_architect,examples/angular_bazel_architect/projects/frontend-lib,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/create-react-app,examples/from_source,examples/jest,examples/jest/ts,examples/jest/ts/src,examples/jest/ts/test,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protobufjs,examples/react_webpack,examples/toolchain,examples/vue,examples/vue/src,examples/vue/src/components/HelloWorld,examples/web_testing,examples/webapp,examples/worker

# Mock versioning command to test the --stamp behavior
build --workspace_status_command="echo BUILD_SCM_VERSION 1.2.3"
Expand Down
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
docs/Built-ins.md linguist-generated=true
docs/Jasmine.md linguist-generated=true
docs/Providers.md linguist-generated=true
docs/Rollup.md linguist-generated=true
docs/TypeScript.md linguist-generated=true
1 change: 0 additions & 1 deletion commitlint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ module.exports = {
'builtin',
'create',
'examples',
'jasmine',
'rollup',
'runfiles',
'terser',
Expand Down
1 change: 0 additions & 1 deletion docs/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ stardoc(
_READMES = {
"Built-ins": "//docs:builtins.md_",
"Core": "//docs:core.md_",
"Jasmine": "//packages/jasmine:README.md",
"Providers": "//docs:providers.md_",
"Rollup": "//packages/rollup:README.md",
}
Expand Down
1 change: 0 additions & 1 deletion docs/Built-ins.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

119 changes: 0 additions & 119 deletions docs/Jasmine.md

This file was deleted.

4 changes: 2 additions & 2 deletions docs/dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ nodejs_binary(
In this case, the `bar` nodejs_binary depends only the `foo` and `baz` npm packages
and all of their transitive deps.

For other rules such as `jasmine_node_test`, fine grained
For other rules fine grained
npm dependencies are specified in the `deps` attribute:

```python
jasmine_node_test(
nodejs_test(
name = "test",
...
deps = [
Expand Down
2 changes: 0 additions & 2 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,8 @@ It also supports running Node.js programs and has a number of useful rules.
This is required when rules have JavaScript code which wants to `require` from peerDependency packages,
since the node resolution algorithm requires the callsite of `require` to be in the node_modules tree.

- [Jasmine](Jasmine.md)
- [Labs](Labs.md)
- [Rollup](Rollup.md)
- [Terser](Terser.md)
- [TypeScript](TypeScript.md)

There are also numerous [examples](examples.md)
Expand Down
53 changes: 0 additions & 53 deletions e2e/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -14,66 +14,13 @@

load(":test.bzl", "e2e_integration_test")

e2e_integration_test(
name = "e2e_bazel_managed_deps",
npm_packages = {
"//packages/jasmine:npm_package": "@bazel/jasmine",
},
# TODO: figure out why this fails on Windows since setting
# symlink_node_modules to False in the test WORKSPACE
tags = ["no-bazelci-windows"],
)

e2e_integration_test(
name = "e2e_coverage",
bazel_commands = [
"info",
"coverage ...",
],
npm_packages = {
"//packages/jasmine:npm_package": "@bazel/jasmine",
},
# Coverage not working on Windows. Looks like a bazel issue.
# ==================== Test output for //:coverage_test:
# ERROR(tools/test/windows/tw.cc:1262) ERROR: src/main/native/windows/process.cc(199): CreateProcessW("C:\users\b\_bazel_b\tpt6yasm\execroot\e2e_coverage\bazel-out\x64_windows-fastbuild\bin\coverage_test.bat.runfiles\bazel_tools\tools\test\collect_coverage.sh" ./coverage_test.bat): The system cannot find the file specified.
# (error: 2)
# ERROR(tools/test/windows/tw.cc:1419) Failed to start test process (arg: C:\users\b\_bazel_b\tpt6yasm\execroot\e2e_coverage\bazel-out\x64_windows-fastbuild\bin\coverage_test.bat.runfiles\bazel_tools\tools\test\collect_coverage.sh)
tags = [
"no-bazelci-windows",
],
)

e2e_integration_test(
name = "e2e_fine_grained_symlinks",
# TODO: figure out why this fails on Windows since setting
# symlink_node_modules to False in the test WORKSPACE
tags = ["no-bazelci-windows"],
)

[e2e_integration_test(
name = "e2e_jasmine_%s" % jasmine_version.replace(".", "_"),
npm_packages = {
"//packages/jasmine:npm_package": "@bazel/jasmine",
},
# use these package.json packages instead
package_json_substitutions = {
"jasmine": jasmine_version,
"jasmine-core": jasmine_version,
},
# TODO: figure out why this fails on Windows since setting
# symlink_node_modules to False in the test WORKSPACE
tags = ["no-bazelci-windows"],
workspace_root = "jasmine",
) for jasmine_version in [
# TODO(6.0): remove old API tests
# Old API
"2.99.x",
"3.9.x",
"3.10.x",
# New API
"4.0.x",
]]

e2e_integration_test(
name = "e2e_node_loader_preserve_symlinks",
# TODO: figure out why this fails on Windows since setting
Expand Down
1 change: 0 additions & 1 deletion e2e/bazel_managed_deps/.bazelignore

This file was deleted.

1 change: 0 additions & 1 deletion e2e/bazel_managed_deps/.bazelrc

This file was deleted.

14 changes: 0 additions & 14 deletions e2e/bazel_managed_deps/BUILD.bazel

This file was deleted.

19 changes: 0 additions & 19 deletions e2e/bazel_managed_deps/README.md

This file was deleted.

45 changes: 0 additions & 45 deletions e2e/bazel_managed_deps/WORKSPACE

This file was deleted.

24 changes: 0 additions & 24 deletions e2e/bazel_managed_deps/deps.spec.js

This file was deleted.

11 changes: 0 additions & 11 deletions e2e/bazel_managed_deps/package.json

This file was deleted.

Loading

0 comments on commit e22631f

Please sign in to comment.