Test for npm_install remove removeNPMAbsolutePaths target cycle regre…

…ssion (#763) This failure only shows up in downstream workspaces so we should use npm_install in a subset of nested workspaces. Changing /examples/parcel & /e2e/bazel_bin to npm_install here.
bazel-contrib · May 28, 2019 · dfa7b99 · dfa7b99
1 parent 04212de
commit dfa7b99
Show file tree

Hide file tree

Showing 10 changed files with 7,253 additions and 5,256 deletions.
diff --git a/e2e/bazel_bin/WORKSPACE b/e2e/bazel_bin/WORKSPACE
@@ -22,10 +22,10 @@ local_repository(
     path = "../../dist/build_bazel_rules_nodejs/release",
 )
 
-load("@build_bazel_rules_nodejs//:defs.bzl", "yarn_install")
+load("@build_bazel_rules_nodejs//:defs.bzl", "npm_install")
 
-yarn_install(
+npm_install(
     name = "npm",
     package_json = "//:package.json",
-    yarn_lock = "//:yarn.lock",
+    package_lock_json = "//:package-lock.json",
 )
diff --git a/e2e/bazel_bin/npm/testy/index.js b/e2e/bazel_bin/npm/testy/index.js
diff --git a/e2e/bazel_bin/package-lock.json b/e2e/bazel_bin/package-lock.json
diff --git a/e2e/bazel_bin/package.json b/e2e/bazel_bin/package.json
@@ -1,7 +1,7 @@
 {
     "private": true,
     "dependencies": {
-      "testy": "file:./npm/testy"
+        "testy": "file:./npm/testy"
     },
     "scripts": {
         "test": "bazel test :test --define=some_env=world"

diff --git a/e2e/bazel_bin/yarn.lock b/e2e/bazel_bin/yarn.lock
diff --git a/examples/parcel/WORKSPACE b/examples/parcel/WORKSPACE
@@ -25,10 +25,10 @@ local_repository(
     path = "../../dist/build_bazel_rules_nodejs/release",
 )
 
-load("@build_bazel_rules_nodejs//:defs.bzl", "yarn_install")
+load("@build_bazel_rules_nodejs//:defs.bzl", "npm_install")
 
-yarn_install(
+npm_install(
     name = "npm",
     package_json = "//:package.json",
-    yarn_lock = "//:yarn.lock",
+    package_lock_json = "//:package-lock.json",
 )
diff --git a/examples/parcel/package-lock.json b/examples/parcel/package-lock.json
diff --git a/examples/parcel/package.json b/examples/parcel/package.json
@@ -1,8 +1,8 @@
 {
     "private": true,
     "devDependencies": {
-        "jasmine": "^3.3.1",
-        "parcel-bundler": "^1.11.0"
+        "jasmine": "3.4.0",
+        "parcel-bundler": "1.12.3"
     },
     "scripts": {
         "test": "bazel run @npm//parcel-bundler/bin:parcel -- --help && bazel test //..."

diff --git a/examples/parcel/parcel.bzl b/examples/parcel/parcel.bzl
@@ -54,6 +54,6 @@ parcel = rule(
     },
     outputs = {
         "bundle": "%{name}.js",
-        "sourcemap": "%{name}.map",
+        "sourcemap": "%{name}.js.map",
     },
 )
diff --git a/examples/parcel/yarn.lock b/examples/parcel/yarn.lock