Skip to content

Commit

Permalink
chore: add --incompatible_exclusive_test_sandboxed to common and --ke…
Browse files Browse the repository at this point in the history
…ep_going for CircleCI
  • Loading branch information
gregmagolan committed Jan 10, 2022
1 parent ddc985c commit d70187e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,6 @@ build --incompatible_no_implicit_file_export
# build --incompatible_struct_has_no_methods
# TODO(alexeagle): turn on this flag when dependencies allow
# build --incompatible_use_platforms_repo_for_constraints

# Allow exclusive tests to run in a sandbox
test --incompatible_exclusive_test_sandboxed
4 changes: 4 additions & 0 deletions .circleci/bazel.rc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
# Don't be spammy in the logs
build --noshow_progress

# Keep going on failures so that we see all failures no CI and not just the first
# and so that we see everything that passes as well
build --keep_going

# Print all the options that apply to the build.
# This helps us diagnose which options override others
# (e.g. /etc/bazel.bazelrc vs. tools/bazel.rc)
Expand Down
2 changes: 2 additions & 0 deletions internal/bazel_integration_test/bazel_integration_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ def rules_nodejs_integration_test(name, **kwargs):
# tests have been completed. Remote execution is disabled for such tests
# because Bazel doesn't have control over what's running on a remote machine.
"exclusive",
# These test should run outside of the sandbox as they fail on bazelci otherwise
"local",
]

# convert the npm packages into the tar output
Expand Down

0 comments on commit d70187e

Please sign in to comment.