Skip to content

Commit

Permalink
fix(builtin): give a longer timeout for _create_build_files
Browse files Browse the repository at this point in the history
A user reports that their build file generation takes longer than 600 seconds.
It's probably a bug that we are so slow, but let's address that separately (maybe in our work for npm v7)

Also note we could have made this timeout user-configurable, but I think the extra API surface isn't worth the benefit.

Fixes #2231
  • Loading branch information
Alex Eagle committed Oct 21, 2020
1 parent 22b0a8e commit 5d405a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/npm_install/npm_install.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def _create_build_files(repository_ctx, rule_type, node, lock_file):
str(repository_ctx.attr.strict_visibility),
",".join(repository_ctx.attr.included_files),
native.bazel_version,
])
], timeout = 1200) # double the default timeout in case of many packages, see #2231
if result.return_code:
fail("generate_build_file.ts failed: \nSTDOUT:\n%s\nSTDERR:\n%s" % (result.stdout, result.stderr))

Expand Down

0 comments on commit 5d405a7

Please sign in to comment.