Skip to content

Commit

Permalink
build: set --incompatible_restrict_string_escapes and --incompatible_…
Browse files Browse the repository at this point in the history
…no_implicit_file_export (#2069)

* build: changes to flip --incompatible_no_implicit_file_export #1508
* build: set --incompatible_restrict_string_escapes #1301
  • Loading branch information
mattem authored Jul 23, 2020
1 parent 1b40827 commit 3af2449
Show file tree
Hide file tree
Showing 9 changed files with 45 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,7 @@ build:docker-sandbox --experimental_docker_verbose
build:docker-sandbox --experimental_enable_docker_sandbox
# This is the same image used on BazelCI rbe_ubuntu1604 job
build:docker-sandbox --experimental_docker_image=gcr.io/cloud-marketplace/google/rbe-ubuntu16-04

# Incompatible flags to run with
build --incompatible_no_implicit_file_export
build --incompatible_restrict_string_escapes
9 changes: 9 additions & 0 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,17 @@ exports_files([
"tsconfig.json",
"package.json",
"bootstrap.js",
"LICENSE",
])

exports_files(
[
"providers.bzl",
"index.for_docs.bzl",
],
visibility = ["//docs:__subpackages__"],
)

bzl_library(
name = "bzl",
srcs = [
Expand Down
6 changes: 6 additions & 0 deletions internal/node/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")

package(default_visibility = ["//visibility:public"])

exports_files([
"node_patches.js",
"require_patch.js",
"loader.js",
])

bzl_library(
name = "bzl",
srcs = glob(["*.bzl"]),
Expand Down
8 changes: 8 additions & 0 deletions packages/cypress/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "co

package(default_visibility = ["//visibility:public"])

exports_files(
[
"internal/plugins/index.template.js",
"internal/run-cypress.js",
],
visibility = ["//packages/cypress/test:__subpackages__"],
)

codeowners(
teams = ["@mrmeku"],
)
Expand Down
2 changes: 2 additions & 0 deletions packages/jasmine/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "co

package(default_visibility = ["//visibility:public"])

exports_files(["jasmine_runner.js"])

bzl_library(
name = "bzl",
srcs = glob(["*.bzl"]),
Expand Down
2 changes: 2 additions & 0 deletions packages/karma/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "co

package(default_visibility = ["//visibility:public"])

exports_files(["karma.conf.js"])

ts_library(
name = "bazel_karma_lib",
srcs = glob(["*.ts"]),
Expand Down
5 changes: 5 additions & 0 deletions packages/protractor/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ load("//third_party/github.com/bazelbuild/bazel-skylib:rules/copy_file.bzl", "co

package(default_visibility = ["//visibility:public"])

exports_files(
["protractor.conf.js"],
visibility = ["//packages/protractor/test:__subpackages__"],
)

bzl_library(
name = "bzl",
testonly = True,
Expand Down
5 changes: 4 additions & 1 deletion packages/rollup/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ codeowners(
teams = ["@jbedard"],
)

exports_files(["rollup.config.js"])
exports_files([
"rollup.config.js",
"index.js",
])

bzl_library(
name = "bzl",
Expand Down
5 changes: 5 additions & 0 deletions packages/terser/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ package(default_visibility = ["//visibility:public"])

exports_files(["terser_config.default.json"])

exports_files(
["index.js"],
visibility = ["//packages/terser:__subpackages__"],
)

bzl_library(
name = "bzl",
srcs = glob(["*.bzl"]),
Expand Down

0 comments on commit 3af2449

Please sign in to comment.