chore: concatjs shouldn't rely on hardcoded @nodejs name (#3163)

bazel-contrib · Dec 22, 2021 · 0a7d5c7 · 0a7d5c7
1 parent 552178e
commit 0a7d5c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/docs/Concatjs.md b/docs/Concatjs.md
@@ -233,7 +233,7 @@ Defaults to `@npm//@bazel/concatjs/devserver:devserver`
 (*<a href="https://bazel.build/docs/build-ref.html#labels">Label</a>*): Go based devserver executable for the host platform.
             Defaults to precompiled go binary setup by @bazel/typescript npm package
 
-Defaults to `@npm//@bazel/concatjs/devserver:devserver_[platform]`
+Defaults to `@npm//@bazel/concatjs/devserver:devserver`
 
 <h4 id="concatjs_devserver-entry_module">entry_module</h4>
 

diff --git a/packages/concatjs/devserver/concatjs_devserver.bzl b/packages/concatjs/devserver/concatjs_devserver.bzl
@@ -19,7 +19,6 @@ load(
     "@build_bazel_rules_nodejs//internal/js_library:js_library.bzl",
     "write_amd_names_shim",
 )
-load("@nodejs//:index.bzl", "host_platform")
 
 # Avoid using non-normalized paths (workspace/../other_workspace/path)
 def _to_manifest_path(ctx, file):
@@ -158,7 +157,7 @@ concatjs_devserver = rule(
         "devserver_host": attr.label(
             doc = """Go based devserver executable for the host platform.
             Defaults to precompiled go binary setup by @bazel/typescript npm package""",
-            default = Label("//packages/concatjs/devserver:devserver_%s" % host_platform),
+            default = Label("//packages/concatjs/devserver"),
             executable = True,
             cfg = "host",
         ),