Skip to content

Commit

Permalink
Minimum Bazel version is now 0.26.0 as yarn_install & npm_install dep…
Browse files Browse the repository at this point in the history
…end on managed_directories by default (#704)
  • Loading branch information
gregmagolan authored and alexeagle committed May 22, 2019
1 parent c91b87c commit 012a21e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ load("//internal/common:check_bazel_version.bzl", "check_bazel_version")

# 0.18.0: support for .bazelignore
# 0.23.0: required fix for pkg_tar strip_prefix
check_bazel_version(minimum_bazel_version = "0.23.0")
# 0.26.0: managed_directories feature added
check_bazel_version(minimum_bazel_version = "0.26.0")

#
# Load and install our dependencies downloaded above.
Expand Down
2 changes: 1 addition & 1 deletion internal/common/check_bazel_version.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def check_bazel_version(minimum_bazel_version, message = ""):
```
# in WORKSPACE:
load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version")
check_bazel_version("0.11.0")
check_bazel_version("0.26.0")
```
Args:
Expand Down
3 changes: 2 additions & 1 deletion internal/node/node_repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,8 @@ def node_repositories(
# 0.14.0: @bazel_tools//tools/bash/runfiles is required for nodejs
# 0.17.1: allow @ in package names is required for fine grained deps
# 0.21.0: repository_ctx.report_progress API
check_bazel_version("0.21.0")
# 0.26.0: managed_directories feature added
check_bazel_version("0.26.0")

_maybe(
_nodejs_repo,
Expand Down

0 comments on commit 012a21e

Please sign in to comment.