Track whether a repo is pinned or unpinned by explicit attr #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plobsing
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
Doing this by performing string interpretation on the repo name is a bit brittle. And it works less well under Bzlmod where the unpinned repo name is going to look something like `rules_jvm_external~~maven~unpinned_maven`. After this change, the lockfile pinning script, `@maven//:pin` will use the local machine's Coursier cache (`~/Library/Caches/Coursier` on MacOS) even under Bzlmod. A populated cache makes version resolutions substantially faster to obtain.
plobsing
force-pushed
the
pinned_repo_name-attr
branch
from
614f27e to
1afeb6a
Compare
|
I tested (but did not review in depth) your changes and it does speed things up signifincatly. Thank you. |
Wyverald
approved these changes
Jul 24, 2024
Tab added by misconfigured editor.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this by performing string interpretation on the repo name is a bit
brittle. And it works less well under Bzlmod where the unpinned repo
name is going to look something like
rules_jvm_external~~maven~unpinned_maven.After this change, the lockfile pinning script,
@maven//:pinwill use the localmachine's Coursier cache (
~/Library/Caches/Coursieron MacOS) even underBzlmod. A populated cache makes version resolutions substantially faster to obtain.