-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules_jvm_external 6.1 seems to require artifacts or boms list #1132
Comments
cc @ahumesky |
The opposite configuration also yields the same error: If we specify the |
ted-xie
changed the title
maven_install in WORKSPACE + lockfile generated with bzlmod enabled doesn't work
rules_jvm_external 6.1 seems to require artifacts or boms list
May 13, 2024
ted-xie
added a commit
to ted-xie/rules_android
that referenced
this issue
May 13, 2024
Also adds a consistency check between defs.bzl and MODULE.bazel for the Maven artifacts. Disables the Maven lockfile for WORKSPACE mode due to bazel-contrib/rules_jvm_external#1134. Ultimately, this is a workaround to bazel-contrib/rules_jvm_external#1132.
copybara-service bot
pushed a commit
to bazelbuild/rules_android
that referenced
this issue
May 13, 2024
Also adds a consistency check between defs.bzl and MODULE.bazel for the Maven artifacts. Disables the Maven lockfile for WORKSPACE mode due to bazel-contrib/rules_jvm_external#1134. Ultimately, this is a workaround to bazel-contrib/rules_jvm_external#1132. Closes #231 COPYBARA_INTEGRATE_REVIEW=#231 from ted-xie:maven_changes 643e5f1 PiperOrigin-RevId: 633334440 Change-Id: I9de06529495846e3a72a50d394cdf90f6335923b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See my repro here: https://github.com/ted-xie/maven_install_bzlmod_onoff. The rules_jvm_external version is 6.1. I am using bazelisk with
USE_BAZEL_VERSION=f3133764576d9e9d12d88486d6ec2031beb3ddaf
.I would like to have a single source of truth for maven install artifacts. I would like the MODULE.bazel
maven.install()
artifact list to be the source of truth.In this example, I specify the artifact list in MODULE.bazel, generate a lock file, and then in WORKSPACE read that lock file. My expectation is that
bazel build
commands with--noenable_bzlmod
and--enable_bzlmod
should work identically.However, I get a
rules_jvm_external
error when building with bzlmod disabled:Meanwhile, the build works correctly with bzlmod disabled:
The text was updated successfully, but these errors were encountered: