Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please help bump PMD version #176

Closed
rdesgroppes opened this issue Apr 20, 2023 · 2 comments · Fixed by #178
Closed

Please help bump PMD version #176

rdesgroppes opened this issue Apr 20, 2023 · 2 comments · Fixed by #178

Comments

@rdesgroppes
Copy link
Contributor

rdesgroppes commented Apr 20, 2023 •
edited
Loading

Currently shipped PMD version is at 6.46.0, released in May 2022.
Since then, a handful of fixes & enhancements got released, among which:

The latter also states that:

This release is the last planned release of PMD 6. The first version 6.0.0 was released in December 2017. Over the course of more than 5 years we published almost every month a new minor version of PMD 6 with new features and improvements.

Before PMD 7 is out, I therefore gave a try bumping up PMD version to 6.55.0 but miserably failed running tools/update-dependencies.sh, which doesn't work on my machine:

$ ./tools/update-dependencies.sh
go: downloading github.com/rs/zerolog v1.26.1
[...]
ERROR: Skipping '@unpinned_maven//:pin': No repository visible as '@unpinned_maven' from main repository
WARNING: Target pattern parsing failed.
ERROR: No repository visible as '@unpinned_maven' from main repository
INFO: Elapsed time: 0.096s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
ERROR: Build failed. Not running target

Could you please help (or do) bump PMD version to 6.55.0?
@rdesgroppes
Copy link
Contributor Author

@shs96c Any idea? Thanks in advance!

@rdesgroppes
Copy link
Contributor Author

rdesgroppes commented Apr 26, 2023 •
edited
Loading

Updates:

  1. seems Avoid using the maven namespace #115 didn't account for the presence of maven in tools/update-dependencies.sh,
  2. ... and that bzlmod needs to be disabled when re-pinning.

PR:

@rdesgroppes rdesgroppes mentioned this issue Apr 26, 2023
Merged
rdesgroppes added a commit to rdesgroppes/rules_jvm that referenced this issue Apr 26, 2023
@rdesgroppes
Bump PMD version to last planned release (6.55.0)
9ed8991 
Currently shipped PMD version is at 6.46.0, released in May 2022.
Since then, a handful of fixes & enhancements got released, among which:
- pmd/pmd#3936 in 6.47.0
- pmd/pmd#4015 in 6.48.0
- pmd/pmd#4082 in 6.49.0
- pmd/pmd#4085 in 6.50.0
- pmd/pmd#4139 in 6.51.0
- pmd/pmd#4152 in 6.52.0
- pmd/pmd#4266 in 6.53.0
- pmd/pmd#4364 in 6.54.0
- pmd/pmd#4333 in 6.55.0

The latter also
[states](https://docs.pmd-code.org/pmd-doc-6.55.0/pmd_release_notes.html#pmd-7-development)
that:
> This release is the last planned release of PMD 6. The first version
> 6.0.0 was released in December 2017. Over the course of more than 5
> years we published almost every month a new minor version of PMD 6
> with new features and improvements.

The present change therefore bumps the shipped PMD version to 6.55.0 so
as to benefit from its last improvements, before envisioning an upgrade
to PMD 7, [when ready](https://github.com/pmd/pmd/milestone/19).

Closes bazel-contrib#176.
@rdesgroppes rdesgroppes mentioned this issue Apr 26, 2023
Merged
rdesgroppes added a commit to rdesgroppes/rules_jvm that referenced this issue Apr 26, 2023
@rdesgroppes
Bump PMD version to last planned release (6.55.0)
23e1897 
closes bazel-contrib#176.

Currently shipped PMD version is at 6.46.0, released in May 2022.
Since then, a handful of fixes & enhancements got released, among which:
- pmd/pmd#3936 in 6.47.0
- pmd/pmd#4015 in 6.48.0
- pmd/pmd#4082 in 6.49.0
- pmd/pmd#4085 in 6.50.0
- pmd/pmd#4139 in 6.51.0
- pmd/pmd#4152 in 6.52.0
- pmd/pmd#4266 in 6.53.0
- pmd/pmd#4364 in 6.54.0
- pmd/pmd#4333 in 6.55.0

The latter also
[states](https://docs.pmd-code.org/pmd-doc-6.55.0/pmd_release_notes.html#pmd-7-development)
that:
> This release is the last planned release of PMD 6. The first version
> 6.0.0 was released in December 2017. Over the course of more than 5
> years we published almost every month a new minor version of PMD 6
> with new features and improvements.

The present change therefore bumps the shipped PMD version to 6.55.0 so
as to benefit from its last improvements, before envisioning an upgrade
to PMD 7, [when ready](https://github.com/pmd/pmd/milestone/19).
illicitonion pushed a commit that referenced this issue Apr 26, 2023
@rdesgroppes
Bump PMD version to last planned release (6.55.0) (#178)
d99cc64 
closes #176.

Currently shipped PMD version is at 6.46.0, released in May 2022.
Since then, a handful of fixes & enhancements got released, among which:
- pmd/pmd#3936 in 6.47.0
- pmd/pmd#4015 in 6.48.0
- pmd/pmd#4082 in 6.49.0
- pmd/pmd#4085 in 6.50.0
- pmd/pmd#4139 in 6.51.0
- pmd/pmd#4152 in 6.52.0
- pmd/pmd#4266 in 6.53.0
- pmd/pmd#4364 in 6.54.0
- pmd/pmd#4333 in 6.55.0

The latter also
[states](https://docs.pmd-code.org/pmd-doc-6.55.0/pmd_release_notes.html#pmd-7-development)
that:
> This release is the last planned release of PMD 6. The first version
> 6.0.0 was released in December 2017. Over the course of more than 5
> years we published almost every month a new minor version of PMD 6
> with new features and improvements.

The present change therefore bumps the shipped PMD version to 6.55.0 so
as to benefit from its last improvements, before envisioning an upgrade
to PMD 7, [when ready](https://github.com/pmd/pmd/milestone/19).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump PMD version to last planned release (6.55.0) rdesgroppes/rules_jvm
1 participant
@rdesgroppes