Add to imports bin_dir so generated files can be propertly handled #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszstrejczek
requested review from
Globegitter and
sparkprime
as code owners
|
@tomaszstrejczek thanks for the contribution - can you please add a test that verifies this behaviour? |
|
I'm not sure this is still relevant? It is very old. |
|
This should no longer be necessary with #182 having landed. Thanks for your patch regardless, @tomaszstrejczek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't handle libraries which are generated via different rules (for example genrule) because files generated this way are stored in ctx.bin_dir directory which is not added as an import location. The PR adds to import ctx.bin_dir.