Switching coverage to a better mechanism #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by tracking all coverage variables from the full transitive dependacy set, which allows multiple packages to be covered at once. This also normalises the names of cover variables so that two separate covers of the same file will produce actions that merge. It also tracks the cover variables directly, rather than inferring them from the file names, which also means the test generator does not need to process the generated files.
jayconrod
approved these changes
Aug 11, 2017
go/private/test.bzl
Outdated
| covered_libs = [] | ||
| for golib in depset([golib]) + golib.transitive: | ||
| if golib.cover_vars: | ||
| covered_libs += [golib] |
| @@ -66,7 +75,7 @@ def _go_test_impl(ctx): | |||
| library = None, | |||
| want_coverage = False, | |||
| importpath = ctx.label.name + "~testmain~", | |||
| golibs = [golib], | |||
| golibs = [golib] + covered_libs, | |||
There was a problem hiding this comment.
We'll end up passing golib in multiple times here. This could go in another CL, but I think emit_library_actions should accept a depset instead of a list for this parameter.
There was a problem hiding this comment.
It actually does not matter because emit_library_actions immediately collects the libs into depsets internally (direct and transitive)
This was in another cl, it forwards the cover vars from the library attribute of a test
linuxerwang
reviewed
Aug 11, 2017
| cover_var = "GoCover_%d" % count | ||
| out = ctx.new_file(out_object, out_object.basename + '_' + src.basename[:-3] + '_' + cover_var + '.cover.go') | ||
| cover_var = "Cover_" + src.basename[:-3].replace("-", "_").replace(".", "_") | ||
| cover_vars += ["{}={}".format(cover_var,src.short_path)] |
There was a problem hiding this comment.
nit: one space after ",".
linuxerwang
reviewed
Aug 11, 2017
| '--output', | ||
| main_go.path, | ||
| ] | ||
| cover_vars = [] |
linuxerwang
reviewed
Aug 11, 2017
| @@ -93,6 +62,7 @@ import ( | |||
| "flag" | |||
| "log" | |||
| "os" | |||
| "fmt" | |||
vorburger
added a commit
to vorburger/rules_go
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by tracking all coverage variables from the full transitive dependacy
set, which allows multiple packages to be covered at once.
This also normalises the names of cover variables so that two separate covers of
the same file will produce actions that merge.
It also tracks the cover variables directly, rather than inferring them from the
file names, which also means the test generator does not need to process the
generated files.
@linuxerwang you might want to check these changes, as it's based heavily on the work you did.