Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bazel test //... to run out-of-the-box #4150

Merged
merged 4 commits into from
Oct 21, 2024

Commits on Oct 20, 2024

  1. Update to gazelle 0.39.1

    This fixes a few of the TODOs in the WORKSPACE file and changes a lot
    about the popular_repos tests.
    
    This commit also provides a default value of
    `--java_runtime_version=remotejdk_21` just for the bazel_test in
    lcov_coverage_test.go so that contributors who don't
    have a JAVA_HOME on the host system can still get the
    lcov_coverage_test.go to pass by default.
    
    Oh, and it also fixes a TODO in the repository's `.bazelrc` file.
    eljobe committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f5bd3c2 View commit details
    Browse the repository at this point in the history
  2. Wrap generate_imported_dylib.sh in genrules

    As a contributor to the project, I expect to be able to clone the
    repository, go to the master branch and run `bazel test //...` and
    have it work.
    
    But, before this change, just like the CI system, contributors were
    also expected to run `./tests/core/cgo/generate_imported_dylib.sh`
    manually. Well ... no more!
    eljobe committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    fb8b11a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Fix the Ubuntu 18 build

    That script should no longer be run.
    eljobe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    832e01c View commit details
    Browse the repository at this point in the history
  2. Attempt to fix Ubuntu, and Windows builds on CI

    The Ubuntu build is breaking because jdk21 is not supported on that
    OS, and the Windows build is failing because some of the tools pprof
    and diffp are not available on Windows.
    eljobe committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    555a6c0 View commit details
    Browse the repository at this point in the history