Speedup compilepkg args handling #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
force-pushed
the
compilepkg_args
branch
from
638d084 to
54772f5
Compare
|
This is a nice improvement, including to retained memory. I considered doing this right in the nogo change, but wanted to keep it small. We should wait for the nogo release before we merge this. |
Yep, makes sense. |
|
@fmeum shall we revisit this after bazel8 ships? |
|
Yes, I'll also cut the long due rules_go release! |
dzbarsky
force-pushed
the
compilepkg_args
branch
from
ff1f25c to
c2f42b7
Compare
OK, I've rebased this one. Maybe we can try to land #4030 after the release is cut? |
fmeum
force-pushed
the
compilepkg_args
branch
from
c2f42b7 to
a57ce95
Compare
fmeum
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Starlark cleanup
What does this PR do? Why is it needed?
A lot of the args between compilepkg and nogo are shared, so we can reuse the
Argsobject. Cleaned up a few other things that showed up in profiles while I was here.Which issues(s) does this PR fix?
Fixes #
Other notes for review