Cleanup _merge_embed #4048
Merged
Cleanup _merge_embed #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
zbarsky/clean-merge
branch
from
e0d041c to
aecc793
Compare
fmeum
reviewed
Aug 16, 2024
|
This has conflicts |
dzbarsky
force-pushed
the
zbarsky/clean-merge
branch
from
aecc793 to
e71110f
Compare
rebased! |
fmeum
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Starlark cleanup
What does this PR do? Why is it needed?
Since only one the lib or one of the embeds can specify cgo, we can simplify this a bit
Which issues(s) does this PR fix?
Fixes #
Other notes for review