Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use depset for SDK files #4014

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Use depset for SDK files #4014

merged 2 commits into from
Aug 11, 2024

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Aug 7, 2024 •
edited
Loading

This PR improves analysis phase time by using depsets.

Example private repo, note go_test_impl and go_binary_impl disappear from the profile and go_library_impl contracts.

Before
image

After
image

@dzbarsky dzbarsky mentioned this pull request Aug 7, 2024
Open
@dzbarsky dzbarsky mentioned this pull request Aug 7, 2024
Closed
@dzbarsky dzbarsky force-pushed the zbarsky/depsets branch 3 times, most recently from d580941 to 56ff98c Compare August 8, 2024 00:51
@fmeum
Copy link
Member

fmeum commented Aug 8, 2024

Could you also update the docs (providers.rst, I think)?

@dzbarsky
Copy link
Contributor Author

Could you also update the docs (providers.rst, I think)?

yep, done

@fmeum fmeum enabled auto-merge (squash) August 11, 2024 06:45
@fmeum fmeum merged commit 3994841 into bazel-contrib:master Aug 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @fmeum