Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the suffixes attribute of go_proto_compiler #3970

Merged

Conversation

leskin-in
Copy link
Contributor

What type of PR is this?

Documentation

What does this PR do? Why is it needed?

go_proto_compiler supports not only the suffix attribute, defining a single output file's suffix, but also the suffixes attribute, enabling the developers to use protoc plugins generating multiple output files for a single .proto file.

Document this previously undocumented attribute.

See the implementation of this attribute in go_proto_compiler.

Copy link

google-cla bot commented Jun 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

`go_proto_compiler` supports not only the `suffix` attribute, defining
a single output file's suffix, but also the `suffixes` attribute,
enabling the developers to use protoc plugins generating multiple output
files for a single `.proto` file.

Document this previously undocumented attribute.

See [the implementation of this attribute in `go_proto_compiler`](https://github.com/bazelbuild/rules_go/blob/93f29a542553f50787233cac7d9006ce300d4079/proto/compiler.bzl#L104)
@fmeum fmeum force-pushed the proto-core-rst-add-suffixes-attribute branch from cc7d37a to f8378e0 Compare August 21, 2024 18:19
@fmeum fmeum enabled auto-merge (squash) August 21, 2024 18:19
@fmeum fmeum merged commit 8027406 into bazel-contrib:master Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants