Fix revive warning in testmain.go files #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Jun 11, 2024
When configuring nogo() to run the revive linter, we currently see
builds of testmain.go files fail with the following error:
if block ends with call to os.Exit function, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
Let's restructure this code slightly, so that this is no longer an
issue.
fmeum
force-pushed
the
eschouten/20240611-warning
branch
from
ed5c40f
to
cd30a2a
Compare
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Jul 13, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.48.1` -> `v0.49.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.5") #### What's Changed - Add support for path mapping by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3915](https://togithub.com/bazelbuild/rules_go/pull/3915) - Introduce rules_go_unsupported_feature by [@​cramertj](https://togithub.com/cramertj) in [https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955) - Automatically run `bazel mod tidy` in `@rules_go//go` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3927](https://togithub.com/bazelbuild/rules_go/pull/3927) - Fix revive warning in testmain.go files by [@​EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3958](https://togithub.com/bazelbuild/rules_go/pull/3958) - Revert "feat(mode): add `purego` tag when `pure` ([#​3901](https://togithub.com/bazelbuild/rules_go/issues/3901))" by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3961](https://togithub.com/bazelbuild/rules_go/pull/3961) - prepare patch release 0.48.1 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3963](https://togithub.com/bazelbuild/rules_go/pull/3963) - Fix broken link to https://bazel.build/concepts/dependencies#data-dependencies by [@​alexbozhenko](https://togithub.com/alexbozhenko) in [https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960) - docs: Discourage use `go_sdk.host()` in bzlmod.md (see [#​713](https://togithub.com/bazelbuild/rules_go/issues/713)) by [@​vorburger](https://togithub.com/vorburger) in [https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968) - Add linux/ppc64le to GOARCH constraints by [@​c16a](https://togithub.com/c16a) in [https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975) - gopackagesdriver: Make kind query regexes anchored by [@​jscissr](https://togithub.com/jscissr) in [https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978) - Add a full `fs.FS` implementation to `runfiles` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3969](https://togithub.com/bazelbuild/rules_go/pull/3969) - update readmes for latest release by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3988](https://togithub.com/bazelbuild/rules_go/pull/3988) - prepare release 0.49.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3989](https://togithub.com/bazelbuild/rules_go/pull/3989) #### New Contributors - [@​cramertj](https://togithub.com/cramertj) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955) - [@​alexbozhenko](https://togithub.com/alexbozhenko) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960) - [@​vorburger](https://togithub.com/vorburger) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968) - [@​c16a](https://togithub.com/c16a) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975) - [@​jscissr](https://togithub.com/jscissr) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978) **Full Changelog**: bazel-contrib/rules_go@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Jul 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.48.1` -> `v0.49.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.5") #### What's Changed - Add support for path mapping by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3915](https://togithub.com/bazelbuild/rules_go/pull/3915) - Introduce rules_go_unsupported_feature by [@​cramertj](https://togithub.com/cramertj) in [https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955) - Automatically run `bazel mod tidy` in `@rules_go//go` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3927](https://togithub.com/bazelbuild/rules_go/pull/3927) - Fix revive warning in testmain.go files by [@​EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3958](https://togithub.com/bazelbuild/rules_go/pull/3958) - Revert "feat(mode): add `purego` tag when `pure` ([#​3901](https://togithub.com/bazelbuild/rules_go/issues/3901))" by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3961](https://togithub.com/bazelbuild/rules_go/pull/3961) - prepare patch release 0.48.1 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3963](https://togithub.com/bazelbuild/rules_go/pull/3963) - Fix broken link to https://bazel.build/concepts/dependencies#data-dependencies by [@​alexbozhenko](https://togithub.com/alexbozhenko) in [https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960) - docs: Discourage use `go_sdk.host()` in bzlmod.md (see [#​713](https://togithub.com/bazelbuild/rules_go/issues/713)) by [@​vorburger](https://togithub.com/vorburger) in [https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968) - Add linux/ppc64le to GOARCH constraints by [@​c16a](https://togithub.com/c16a) in [https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975) - gopackagesdriver: Make kind query regexes anchored by [@​jscissr](https://togithub.com/jscissr) in [https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978) - Add a full `fs.FS` implementation to `runfiles` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3969](https://togithub.com/bazelbuild/rules_go/pull/3969) - update readmes for latest release by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3988](https://togithub.com/bazelbuild/rules_go/pull/3988) - prepare release 0.49.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3989](https://togithub.com/bazelbuild/rules_go/pull/3989) #### New Contributors - [@​cramertj](https://togithub.com/cramertj) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955) - [@​alexbozhenko](https://togithub.com/alexbozhenko) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960) - [@​vorburger](https://togithub.com/vorburger) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968) - [@​c16a](https://togithub.com/c16a) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975) - [@​jscissr](https://togithub.com/jscissr) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978) **Full Changelog**: bazel-contrib/rules_go@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
rrbutani
referenced
this pull request
in bazel-contrib/toolchains_llvm
Jul 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.48.1` -> `v0.49.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.5") #### What's Changed - Add support for path mapping by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3915](https://togithub.com/bazelbuild/rules_go/pull/3915) - Introduce rules_go_unsupported_feature by [@​cramertj](https://togithub.com/cramertj) in [https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955) - Automatically run `bazel mod tidy` in `@rules_go//go` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3927](https://togithub.com/bazelbuild/rules_go/pull/3927) - Fix revive warning in testmain.go files by [@​EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3958](https://togithub.com/bazelbuild/rules_go/pull/3958) - Revert "feat(mode): add `purego` tag when `pure` ([#​3901](https://togithub.com/bazelbuild/rules_go/issues/3901))" by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3961](https://togithub.com/bazelbuild/rules_go/pull/3961) - prepare patch release 0.48.1 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3963](https://togithub.com/bazelbuild/rules_go/pull/3963) - Fix broken link to https://bazel.build/concepts/dependencies#data-dependencies by [@​alexbozhenko](https://togithub.com/alexbozhenko) in [https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960) - docs: Discourage use `go_sdk.host()` in bzlmod.md (see [#​713](https://togithub.com/bazelbuild/rules_go/issues/713)) by [@​vorburger](https://togithub.com/vorburger) in [https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968) - Add linux/ppc64le to GOARCH constraints by [@​c16a](https://togithub.com/c16a) in [https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975) - gopackagesdriver: Make kind query regexes anchored by [@​jscissr](https://togithub.com/jscissr) in [https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978) - Add a full `fs.FS` implementation to `runfiles` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3969](https://togithub.com/bazelbuild/rules_go/pull/3969) - update readmes for latest release by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3988](https://togithub.com/bazelbuild/rules_go/pull/3988) - prepare release 0.49.0 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3989](https://togithub.com/bazelbuild/rules_go/pull/3989) #### New Contributors - [@​cramertj](https://togithub.com/cramertj) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955) - [@​alexbozhenko](https://togithub.com/alexbozhenko) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960) - [@​vorburger](https://togithub.com/vorburger) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968) - [@​c16a](https://togithub.com/c16a) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975) - [@​jscissr](https://togithub.com/jscissr) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978) **Full Changelog**: bazel-contrib/rules_go@v0.48.0...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
When configuring nogo() to run the revive linter, we currently see builds of testmain.go files fail with the following error:
Let's restructure this code slightly, so that this is no longer an issue.
Which issues(s) does this PR fix?
N/A
Other notes for review