Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run bazel mod tidy in @rules_go//go #3927

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Apr 24, 2024

What type of PR is this?

Feature

What does this PR do? Why is it needed?

bazel mod tidy is run if supported and if relevant files change due to the command.

Which issues(s) does this PR fix?

Fixes #3900
Fixes bazel-contrib/bazel-gazelle#1749

Other notes for review

@stefanpenner
Copy link
Contributor

Just checking, will this also work for users of go.work workspaces?

@fmeum
Copy link
Member Author

fmeum commented May 7, 2024

Just checking, will this also work for users of go.work workspaces?

This requires adding the relevant files to https://github.com/bazelbuild/bazel-gazelle/blob/7c84c339075a992ea1a6f720899d91c0e047efe2/internal/bzlmod/go_deps.bzl#L657. Maybe that already happens with the fake go.mod files we create for a workspace?

`bazel mod tidy` is run if supported and if relevant files change due to the command.
@fmeum fmeum enabled auto-merge (squash) June 11, 2024 15:07
@fmeum fmeum merged commit a24a63e into master Jun 11, 2024
5 checks passed
@fmeum fmeum deleted the bazel-mod-tidy branch June 11, 2024 15:35
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/bazel-starlib Jul 13, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.48.1` -> `v0.49.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.22.5")

#### What's Changed

- Add support for path mapping by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3915](https://togithub.com/bazelbuild/rules_go/pull/3915)
- Introduce rules_go_unsupported_feature by
[@&#8203;cramertj](https://togithub.com/cramertj) in
[https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955)
- Automatically run `bazel mod tidy` in `@rules_go//go` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3927](https://togithub.com/bazelbuild/rules_go/pull/3927)
- Fix revive warning in testmain.go files by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[https://github.com/bazelbuild/rules_go/pull/3958](https://togithub.com/bazelbuild/rules_go/pull/3958)
- Revert "feat(mode): add `purego` tag when `pure`
([#&#8203;3901](https://togithub.com/bazelbuild/rules_go/issues/3901))"
by [@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3961](https://togithub.com/bazelbuild/rules_go/pull/3961)
- prepare patch release 0.48.1 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3963](https://togithub.com/bazelbuild/rules_go/pull/3963)
- Fix broken link to
https://bazel.build/concepts/dependencies#data-dependencies by
[@&#8203;alexbozhenko](https://togithub.com/alexbozhenko) in
[https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960)
- docs: Discourage use `go_sdk.host()` in bzlmod.md (see
[#&#8203;713](https://togithub.com/bazelbuild/rules_go/issues/713)) by
[@&#8203;vorburger](https://togithub.com/vorburger) in
[https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968)
- Add linux/ppc64le to GOARCH constraints by
[@&#8203;c16a](https://togithub.com/c16a) in
[https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975)
- gopackagesdriver: Make kind query regexes anchored by
[@&#8203;jscissr](https://togithub.com/jscissr) in
[https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978)
- Add a full `fs.FS` implementation to `runfiles` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3969](https://togithub.com/bazelbuild/rules_go/pull/3969)
- update readmes for latest release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3988](https://togithub.com/bazelbuild/rules_go/pull/3988)
- prepare release 0.49.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3989](https://togithub.com/bazelbuild/rules_go/pull/3989)

#### New Contributors

- [@&#8203;cramertj](https://togithub.com/cramertj) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955)
- [@&#8203;alexbozhenko](https://togithub.com/alexbozhenko) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960)
- [@&#8203;vorburger](https://togithub.com/vorburger) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968)
- [@&#8203;c16a](https://togithub.com/c16a) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975)
- [@&#8203;jscissr](https://togithub.com/jscissr) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978)

**Full Changelog**:
bazel-contrib/rules_go@v0.48.0...v0.49.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot referenced this pull request in kreempuff/rules_unreal_engine Jul 13, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.48.1` -> `v0.49.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.22.5")

#### What's Changed

- Add support for path mapping by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3915](https://togithub.com/bazelbuild/rules_go/pull/3915)
- Introduce rules_go_unsupported_feature by
[@&#8203;cramertj](https://togithub.com/cramertj) in
[https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955)
- Automatically run `bazel mod tidy` in `@rules_go//go` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3927](https://togithub.com/bazelbuild/rules_go/pull/3927)
- Fix revive warning in testmain.go files by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[https://github.com/bazelbuild/rules_go/pull/3958](https://togithub.com/bazelbuild/rules_go/pull/3958)
- Revert "feat(mode): add `purego` tag when `pure`
([#&#8203;3901](https://togithub.com/bazelbuild/rules_go/issues/3901))"
by [@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3961](https://togithub.com/bazelbuild/rules_go/pull/3961)
- prepare patch release 0.48.1 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3963](https://togithub.com/bazelbuild/rules_go/pull/3963)
- Fix broken link to
https://bazel.build/concepts/dependencies#data-dependencies by
[@&#8203;alexbozhenko](https://togithub.com/alexbozhenko) in
[https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960)
- docs: Discourage use `go_sdk.host()` in bzlmod.md (see
[#&#8203;713](https://togithub.com/bazelbuild/rules_go/issues/713)) by
[@&#8203;vorburger](https://togithub.com/vorburger) in
[https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968)
- Add linux/ppc64le to GOARCH constraints by
[@&#8203;c16a](https://togithub.com/c16a) in
[https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975)
- gopackagesdriver: Make kind query regexes anchored by
[@&#8203;jscissr](https://togithub.com/jscissr) in
[https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978)
- Add a full `fs.FS` implementation to `runfiles` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3969](https://togithub.com/bazelbuild/rules_go/pull/3969)
- update readmes for latest release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3988](https://togithub.com/bazelbuild/rules_go/pull/3988)
- prepare release 0.49.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3989](https://togithub.com/bazelbuild/rules_go/pull/3989)

#### New Contributors

- [@&#8203;cramertj](https://togithub.com/cramertj) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955)
- [@&#8203;alexbozhenko](https://togithub.com/alexbozhenko) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960)
- [@&#8203;vorburger](https://togithub.com/vorburger) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968)
- [@&#8203;c16a](https://togithub.com/c16a) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975)
- [@&#8203;jscissr](https://togithub.com/jscissr) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978)

**Full Changelog**:
bazel-contrib/rules_go@v0.48.0...v0.49.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
rrbutani referenced this pull request in bazel-contrib/toolchains_llvm Jul 13, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.48.1` -> `v0.49.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.49.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.49.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.1...v0.49.0)

#### `WORKSPACE` code

load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl",
"http_archive")

    http_archive(
        name = "io_bazel_rules_go",
sha256 =
"d93ef02f1e72c82d8bb3d5169519b36167b33cf68c252525e3b9d3d5dd143de7",
        urls = [

"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip",

"https://github.com/bazelbuild/rules_go/releases/download/v0.49.0/rules_go-v0.49.0.zip",
        ],
    )

load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains",
"go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.22.5")

#### What's Changed

- Add support for path mapping by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3915](https://togithub.com/bazelbuild/rules_go/pull/3915)
- Introduce rules_go_unsupported_feature by
[@&#8203;cramertj](https://togithub.com/cramertj) in
[https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955)
- Automatically run `bazel mod tidy` in `@rules_go//go` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3927](https://togithub.com/bazelbuild/rules_go/pull/3927)
- Fix revive warning in testmain.go files by
[@&#8203;EdSchouten](https://togithub.com/EdSchouten) in
[https://github.com/bazelbuild/rules_go/pull/3958](https://togithub.com/bazelbuild/rules_go/pull/3958)
- Revert "feat(mode): add `purego` tag when `pure`
([#&#8203;3901](https://togithub.com/bazelbuild/rules_go/issues/3901))"
by [@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3961](https://togithub.com/bazelbuild/rules_go/pull/3961)
- prepare patch release 0.48.1 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3963](https://togithub.com/bazelbuild/rules_go/pull/3963)
- Fix broken link to
https://bazel.build/concepts/dependencies#data-dependencies by
[@&#8203;alexbozhenko](https://togithub.com/alexbozhenko) in
[https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960)
- docs: Discourage use `go_sdk.host()` in bzlmod.md (see
[#&#8203;713](https://togithub.com/bazelbuild/rules_go/issues/713)) by
[@&#8203;vorburger](https://togithub.com/vorburger) in
[https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968)
- Add linux/ppc64le to GOARCH constraints by
[@&#8203;c16a](https://togithub.com/c16a) in
[https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975)
- gopackagesdriver: Make kind query regexes anchored by
[@&#8203;jscissr](https://togithub.com/jscissr) in
[https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978)
- Add a full `fs.FS` implementation to `runfiles` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3969](https://togithub.com/bazelbuild/rules_go/pull/3969)
- update readmes for latest release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3988](https://togithub.com/bazelbuild/rules_go/pull/3988)
- prepare release 0.49.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3989](https://togithub.com/bazelbuild/rules_go/pull/3989)

#### New Contributors

- [@&#8203;cramertj](https://togithub.com/cramertj) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3955](https://togithub.com/bazelbuild/rules_go/pull/3955)
- [@&#8203;alexbozhenko](https://togithub.com/alexbozhenko) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3960](https://togithub.com/bazelbuild/rules_go/pull/3960)
- [@&#8203;vorburger](https://togithub.com/vorburger) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3968](https://togithub.com/bazelbuild/rules_go/pull/3968)
- [@&#8203;c16a](https://togithub.com/c16a) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3975](https://togithub.com/bazelbuild/rules_go/pull/3975)
- [@&#8203;jscissr](https://togithub.com/jscissr) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3978](https://togithub.com/bazelbuild/rules_go/pull/3978)

**Full Changelog**:
bazel-contrib/rules_go@v0.48.0...v0.49.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants