-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting test.timeout according to TEST_TIMEOUT #3920
Conversation
f5e46a7
to
e6cb737
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a clean solution to our problems, thanks!
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3861](https://togithub.com/bazelbuild/rules_go/pull/3861) - Update toolchains_llvm URL and hash by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3864](https://togithub.com/bazelbuild/rules_go/pull/3864) - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://togithub.com/Strum355) in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - Make exec cfg check for `//go` stricter by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3867](https://togithub.com/bazelbuild/rules_go/pull/3867) - Fixes the Bazel CI error by [@​sgowroji](https://togithub.com/sgowroji) in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3866](https://togithub.com/bazelbuild/rules_go/pull/3866) - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - fix sdk download for common execution platforms by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - Bump Go version to 1.21.8 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3880](https://togithub.com/bazelbuild/rules_go/pull/3880) - Update README.rst to point to correct GH release tags by [@​dcarney](https://togithub.com/dcarney) in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - Update bzlmod.md fix typo by [@​mmrath](https://togithub.com/mmrath) in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://togithub.com/hauserx) in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - gopackagesdriver: move and simplify test by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3856](https://togithub.com/bazelbuild/rules_go/pull/3856) - Support Go version schema change since 1.21 by [@​baizhenyu](https://togithub.com/baizhenyu) in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3893](https://togithub.com/bazelbuild/rules_go/pull/3893) - Revert "improving logging for subcommand failure ([#​3824](https://togithub.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3892](https://togithub.com/bazelbuild/rules_go/pull/3892) - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://togithub.com/c-mita) in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - add nogo parsing support for nogo explanations by [@​andyscott](https://togithub.com/andyscott) in [https://github.com/bazelbuild/rules_go/pull/3899](https://togithub.com/bazelbuild/rules_go/pull/3899) - \[nogo] match regexp againts relative paths by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3898](https://togithub.com/bazelbuild/rules_go/pull/3898) - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3903](https://togithub.com/bazelbuild/rules_go/pull/3903) - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://togithub.com/spags-lacework) in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - Reformat with buildifier by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3910](https://togithub.com/bazelbuild/rules_go/pull/3910) - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://togithub.com/OparinE) in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3911](https://togithub.com/bazelbuild/rules_go/pull/3911) - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3918](https://togithub.com/bazelbuild/rules_go/pull/3918) - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3909](https://togithub.com/bazelbuild/rules_go/pull/3909) - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3920](https://togithub.com/bazelbuild/rules_go/pull/3920) - prepare rules_go v 0.47 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3923](https://togithub.com/bazelbuild/rules_go/pull/3923) #### New Contributors - [@​Strum355](https://togithub.com/Strum355) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - [@​sgowroji](https://togithub.com/sgowroji) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - [@​dcarney](https://togithub.com/dcarney) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - [@​mmrath](https://togithub.com/mmrath) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - [@​baizhenyu](https://togithub.com/baizhenyu) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - [@​c-mita](https://togithub.com/c-mita) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - [@​OparinE](https://togithub.com/OparinE) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) **Full Changelog**: bazel-contrib/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3861](https://togithub.com/bazelbuild/rules_go/pull/3861) - Update toolchains_llvm URL and hash by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3864](https://togithub.com/bazelbuild/rules_go/pull/3864) - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://togithub.com/Strum355) in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - Make exec cfg check for `//go` stricter by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3867](https://togithub.com/bazelbuild/rules_go/pull/3867) - Fixes the Bazel CI error by [@​sgowroji](https://togithub.com/sgowroji) in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3866](https://togithub.com/bazelbuild/rules_go/pull/3866) - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - fix sdk download for common execution platforms by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - Bump Go version to 1.21.8 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3880](https://togithub.com/bazelbuild/rules_go/pull/3880) - Update README.rst to point to correct GH release tags by [@​dcarney](https://togithub.com/dcarney) in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - Update bzlmod.md fix typo by [@​mmrath](https://togithub.com/mmrath) in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://togithub.com/hauserx) in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - gopackagesdriver: move and simplify test by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3856](https://togithub.com/bazelbuild/rules_go/pull/3856) - Support Go version schema change since 1.21 by [@​baizhenyu](https://togithub.com/baizhenyu) in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3893](https://togithub.com/bazelbuild/rules_go/pull/3893) - Revert "improving logging for subcommand failure ([#​3824](https://togithub.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3892](https://togithub.com/bazelbuild/rules_go/pull/3892) - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://togithub.com/c-mita) in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - add nogo parsing support for nogo explanations by [@​andyscott](https://togithub.com/andyscott) in [https://github.com/bazelbuild/rules_go/pull/3899](https://togithub.com/bazelbuild/rules_go/pull/3899) - \[nogo] match regexp againts relative paths by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3898](https://togithub.com/bazelbuild/rules_go/pull/3898) - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3903](https://togithub.com/bazelbuild/rules_go/pull/3903) - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://togithub.com/spags-lacework) in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - Reformat with buildifier by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3910](https://togithub.com/bazelbuild/rules_go/pull/3910) - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://togithub.com/OparinE) in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3911](https://togithub.com/bazelbuild/rules_go/pull/3911) - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3918](https://togithub.com/bazelbuild/rules_go/pull/3918) - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3909](https://togithub.com/bazelbuild/rules_go/pull/3909) - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3920](https://togithub.com/bazelbuild/rules_go/pull/3920) - prepare rules_go v 0.47 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3923](https://togithub.com/bazelbuild/rules_go/pull/3923) #### New Contributors - [@​Strum355](https://togithub.com/Strum355) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - [@​sgowroji](https://togithub.com/sgowroji) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - [@​dcarney](https://togithub.com/dcarney) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - [@​mmrath](https://togithub.com/mmrath) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - [@​baizhenyu](https://togithub.com/baizhenyu) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - [@​c-mita](https://togithub.com/c-mita) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - [@​OparinE](https://togithub.com/OparinE) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) **Full Changelog**: bazel-contrib/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3861](https://togithub.com/bazelbuild/rules_go/pull/3861) - Update toolchains_llvm URL and hash by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3864](https://togithub.com/bazelbuild/rules_go/pull/3864) - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://togithub.com/Strum355) in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - Make exec cfg check for `//go` stricter by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3867](https://togithub.com/bazelbuild/rules_go/pull/3867) - Fixes the Bazel CI error by [@​sgowroji](https://togithub.com/sgowroji) in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3866](https://togithub.com/bazelbuild/rules_go/pull/3866) - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - fix sdk download for common execution platforms by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - Bump Go version to 1.21.8 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3880](https://togithub.com/bazelbuild/rules_go/pull/3880) - Update README.rst to point to correct GH release tags by [@​dcarney](https://togithub.com/dcarney) in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - Update bzlmod.md fix typo by [@​mmrath](https://togithub.com/mmrath) in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://togithub.com/hauserx) in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - gopackagesdriver: move and simplify test by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3856](https://togithub.com/bazelbuild/rules_go/pull/3856) - Support Go version schema change since 1.21 by [@​baizhenyu](https://togithub.com/baizhenyu) in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3893](https://togithub.com/bazelbuild/rules_go/pull/3893) - Revert "improving logging for subcommand failure ([#​3824](https://togithub.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3892](https://togithub.com/bazelbuild/rules_go/pull/3892) - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://togithub.com/c-mita) in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - add nogo parsing support for nogo explanations by [@​andyscott](https://togithub.com/andyscott) in [https://github.com/bazelbuild/rules_go/pull/3899](https://togithub.com/bazelbuild/rules_go/pull/3899) - \[nogo] match regexp againts relative paths by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3898](https://togithub.com/bazelbuild/rules_go/pull/3898) - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3903](https://togithub.com/bazelbuild/rules_go/pull/3903) - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://togithub.com/spags-lacework) in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - Reformat with buildifier by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3910](https://togithub.com/bazelbuild/rules_go/pull/3910) - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://togithub.com/OparinE) in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3911](https://togithub.com/bazelbuild/rules_go/pull/3911) - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3918](https://togithub.com/bazelbuild/rules_go/pull/3918) - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3909](https://togithub.com/bazelbuild/rules_go/pull/3909) - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3920](https://togithub.com/bazelbuild/rules_go/pull/3920) - prepare rules_go v 0.47 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3923](https://togithub.com/bazelbuild/rules_go/pull/3923) #### New Contributors - [@​Strum355](https://togithub.com/Strum355) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - [@​sgowroji](https://togithub.com/sgowroji) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - [@​dcarney](https://togithub.com/dcarney) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - [@​mmrath](https://togithub.com/mmrath) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - [@​baizhenyu](https://togithub.com/baizhenyu) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - [@​c-mita](https://togithub.com/c-mita) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - [@​OparinE](https://togithub.com/OparinE) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) **Full Changelog**: bazel-contrib/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
This change broke one of our tests which runs We have to register our own I think this was the original intention of |
// period (15s) expires. | ||
// If TEST_TIMEOUT is not set (e.g., when the test binary is run by Delve for debugging), we don't | ||
// ignore SIGTERM so it can be properly terminated. | ||
signal.Ignore(syscall.SIGTERM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the intent of this being resettable by signal.Reset
? I like that.
In bazel-contrib#3920, a new mechanism to handle test timeout was introduced. However this broke existing tests that use SIGTERM inside. Restore the original behavior.
In bazel-contrib#3920, a new mechanism to handle test timeout was introduced. However this broke existing tests that use SIGTERM inside. Restore the original behavior.
In #3920, a new mechanism to handle test timeout was introduced. However this broke existing tests that use SIGTERM inside. Restore the original behavior.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3861](https://togithub.com/bazelbuild/rules_go/pull/3861) - Update toolchains_llvm URL and hash by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3864](https://togithub.com/bazelbuild/rules_go/pull/3864) - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://togithub.com/Strum355) in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - Make exec cfg check for `//go` stricter by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3867](https://togithub.com/bazelbuild/rules_go/pull/3867) - Fixes the Bazel CI error by [@​sgowroji](https://togithub.com/sgowroji) in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3866](https://togithub.com/bazelbuild/rules_go/pull/3866) - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - fix sdk download for common execution platforms by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - Bump Go version to 1.21.8 by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3880](https://togithub.com/bazelbuild/rules_go/pull/3880) - Update README.rst to point to correct GH release tags by [@​dcarney](https://togithub.com/dcarney) in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - Update bzlmod.md fix typo by [@​mmrath](https://togithub.com/mmrath) in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://togithub.com/hauserx) in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - gopackagesdriver: move and simplify test by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3856](https://togithub.com/bazelbuild/rules_go/pull/3856) - Support Go version schema change since 1.21 by [@​baizhenyu](https://togithub.com/baizhenyu) in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://togithub.com/jayconrod) in [https://github.com/bazelbuild/rules_go/pull/3893](https://togithub.com/bazelbuild/rules_go/pull/3893) - Revert "improving logging for subcommand failure ([#​3824](https://togithub.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3892](https://togithub.com/bazelbuild/rules_go/pull/3892) - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://togithub.com/c-mita) in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - add nogo parsing support for nogo explanations by [@​andyscott](https://togithub.com/andyscott) in [https://github.com/bazelbuild/rules_go/pull/3899](https://togithub.com/bazelbuild/rules_go/pull/3899) - \[nogo] match regexp againts relative paths by [@​scaiper](https://togithub.com/scaiper) in [https://github.com/bazelbuild/rules_go/pull/3898](https://togithub.com/bazelbuild/rules_go/pull/3898) - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3903](https://togithub.com/bazelbuild/rules_go/pull/3903) - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://togithub.com/spags-lacework) in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - Reformat with buildifier by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3910](https://togithub.com/bazelbuild/rules_go/pull/3910) - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://togithub.com/OparinE) in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3911](https://togithub.com/bazelbuild/rules_go/pull/3911) - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3918](https://togithub.com/bazelbuild/rules_go/pull/3918) - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3909](https://togithub.com/bazelbuild/rules_go/pull/3909) - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://togithub.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3920](https://togithub.com/bazelbuild/rules_go/pull/3920) - prepare rules_go v 0.47 by [@​tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3923](https://togithub.com/bazelbuild/rules_go/pull/3923) #### New Contributors - [@​Strum355](https://togithub.com/Strum355) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3863](https://togithub.com/bazelbuild/rules_go/pull/3863) - [@​sgowroji](https://togithub.com/sgowroji) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3869](https://togithub.com/bazelbuild/rules_go/pull/3869) - [@​mattyclarkson](https://togithub.com/mattyclarkson) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3872](https://togithub.com/bazelbuild/rules_go/pull/3872) - [@​scaiper](https://togithub.com/scaiper) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3874](https://togithub.com/bazelbuild/rules_go/pull/3874) - [@​dcarney](https://togithub.com/dcarney) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3881](https://togithub.com/bazelbuild/rules_go/pull/3881) - [@​mmrath](https://togithub.com/mmrath) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3882](https://togithub.com/bazelbuild/rules_go/pull/3882) - [@​hauserx](https://togithub.com/hauserx) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3885](https://togithub.com/bazelbuild/rules_go/pull/3885) - [@​baizhenyu](https://togithub.com/baizhenyu) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3891](https://togithub.com/bazelbuild/rules_go/pull/3891) - [@​c-mita](https://togithub.com/c-mita) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3896](https://togithub.com/bazelbuild/rules_go/pull/3896) - [@​spags-lacework](https://togithub.com/spags-lacework) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3908](https://togithub.com/bazelbuild/rules_go/pull/3908) - [@​OparinE](https://togithub.com/OparinE) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3916](https://togithub.com/bazelbuild/rules_go/pull/3916) **Full Changelog**: bazel-contrib/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This gives us a determinstic location to ignore for goleak, which we previously had, but was removed as part of bazel-contrib#3920.
This gives us a determinstic location to ignore for goleak, which we previously had, but was removed as part of bazel-contrib#3920.
This gives us a determinstic location to ignore for goleak, which we previously had, but was removed as part of #3920.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This is another attempt to make test timeout experience close to "go test". It meets the following requirements:
test.v
is passedThis implements the approach described in #3875 (comment)
Which issues(s) does this PR fix?
Fixes #3875
Other notes for review
cc @rickystewart