go_download_sdk: allow patching to stdlib #3698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-french
force-pushed
the
sdk-patch
branch
2 times, most recently
from
a55e6f4 to
d32e1de
Compare
tyler-french
force-pushed
the
sdk-patch
branch
3 times, most recently
from
001a399 to
abb369a
Compare
tyler-french
force-pushed
the
sdk-patch
branch
2 times, most recently
from
c2f6465 to
d09af6d
Compare
tyler-french
force-pushed
the
sdk-patch
branch
from
d09af6d to
add9f2c
Compare
fmeum
approved these changes
Sep 24, 2023
|
|
||
| detected_version = _detect_sdk_version(ctx, ".") | ||
| patch(ctx, patch_args = _get_patch_args(ctx.attr.patch_strip)) |
There was a problem hiding this comment.
How are we enforcing that version is set here?
| "patch command line tool if `patch_tool` attribute is specified or there are " + | ||
| "arguments other than `-p` in `patch_args` attribute.", | ||
| ), | ||
| "remote_patches": attr.string_dict( |
There was a problem hiding this comment.
I would vote for dropping the remote_* attributes until we see a clear use case for them.
There was a problem hiding this comment.
I see no need to separate out the patch_attrs since they're only used once.
I update the docs in #3716
Closing this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit merges the features from #3670 and #3684
We should be as restrictive as possible since we will need to maintain all uses in the long term.
The signature of the allowed patch arguments allows for
patch_striprather thanpatch_argsto prevent misuse of the patch args. This design decision was also taken by Bzlmod.go_local_sdkandgo_wrap_sdkalso do not allow patching, since these directories/repositories can be modified with patches before being registered as a Go SDK. Allowing these features again is risky as it gives users unnecessary additional control.