cgo: use -I instead of -iquote for source header directories #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go command uses -I for package directories, which makes directories available for "" and <> includes. We should do the same. We no longer use ctx.build_file_path, since that directory might not actually provide any build files, and its value changed in Bazel 3.7.0. Fixes bazel-contrib#2685
jayconrod
pushed a commit
that referenced
this pull request
Oct 26, 2020
The go command uses -I for package directories, which makes directories available for "" and <> includes. We should do the same. We no longer use ctx.build_file_path, since that directory might not actually provide any build files, and its value changed in Bazel 3.7.0. Fixes #2685
jayconrod
pushed a commit
that referenced
this pull request
Oct 26, 2020
The go command uses -I for package directories, which makes directories available for "" and <> includes. We should do the same. We no longer use ctx.build_file_path, since that directory might not actually provide any build files, and its value changed in Bazel 3.7.0. Fixes #2685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go command uses -I for package directories, which makes
directories available for "" and <> includes. We should do the same.
We no longer use ctx.build_file_path, since that directory might not
actually provide any build files, and its value changed in Bazel
3.7.0.
Fixes #2685