go 1.13 compat #2133

steeve · 2019-07-11T11:26:05Z

What version of rules_go are you using?

master as of today

What version of gazelle are you using?

master as of today

What version of Bazel are you using?

0.25.3

What operating system and processor architecture are you using?

darwin_amd64

What did you do?

When using Go 1.13b1:

$ bazel build @bazel_gazelle//language/go/gen_std_package_list

What did you see instead?

bazel build @bazel_gazelle//language/go/gen_std_package_list --verbose_failures
DEBUG: Rule 'io_bazel_rules_go' indicated that a canonical reproducible form can be obtained by modifying arguments shallow_since = "1562800394 -0400"
DEBUG: Rule 'bazel_gazelle' indicated that a canonical reproducible form can be obtained by modifying arguments shallow_since = "1562699102 -0400"
INFO: Analyzed target @bazel_gazelle//language/go/gen_std_package_list:gen_std_package_list (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
ERROR: /private/var/tmp/_bazel_steeve/309ac22c92b055a3e3f78825fe63406b/external/bazel_gazelle/language/go/gen_std_package_list/BUILD.bazel:3:1: GoLink external/bazel_gazelle/language/go/gen_std_package_list/darwin_amd64_debug/gen_std_package_list failed (Exit 1) builder failed: error executing command
  (cd /private/var/tmp/_bazel_steeve/309ac22c92b055a3e3f78825fe63406b/sandbox/darwin-sandbox/1/execroot/co_znly_client_core && \
  exec env - \
    APPLE_SDK_PLATFORM=MacOSX \
    APPLE_SDK_VERSION_OVERRIDE=10.14 \
    CGO_ENABLED=1 \
    GOARCH=amd64 \
    GOOS=darwin \
    GOROOT=external/go_sdk \
    GOROOT_FINAL=GOROOT \
    PATH=external/local_config_cc:/bin:/usr/bin \
    XCODE_VERSION_OVERRIDE=10.2.1.10E1001 \
  bazel-out/host/bin/external/go_sdk/builder link -sdk external/go_sdk -installsuffix darwin_amd64 -tags core_build_snapshot -package_list bazel-out/host/bin/external/go_sdk/packages.txt -o bazel-out/darwin-dbg/bin/external/bazel_gazelle/language/go/gen_std_package_list/darwin_amd64_debug/gen_std_package_list -main bazel-out/darwin-dbg/bin/external/bazel_gazelle/language/go/gen_std_package_list/darwin_amd64_debug/gen_std_package_list%/github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.a -p github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list -- -extld external/local_config_cc/cc_wrapper.sh '-buildid=redacted' -extldflags '-fobjc-link-runtime -headerpad_max_install_names -no-canonical-prefixes -mmacosx-version-min=10.14')
Execution platform: @bazel_tools//platforms:host_platform

Use --sandbox_debug to see verbose messages from the sandbox: builder failed: error executing command
  (cd /private/var/tmp/_bazel_steeve/309ac22c92b055a3e3f78825fe63406b/sandbox/darwin-sandbox/1/execroot/co_znly_client_core && \
  exec env - \
    APPLE_SDK_PLATFORM=MacOSX \
    APPLE_SDK_VERSION_OVERRIDE=10.14 \
    CGO_ENABLED=1 \
    GOARCH=amd64 \
    GOOS=darwin \
    GOROOT=external/go_sdk \
    GOROOT_FINAL=GOROOT \
    PATH=external/local_config_cc:/bin:/usr/bin \
    XCODE_VERSION_OVERRIDE=10.2.1.10E1001 \
  bazel-out/host/bin/external/go_sdk/builder link -sdk external/go_sdk -installsuffix darwin_amd64 -tags core_build_snapshot -package_list bazel-out/host/bin/external/go_sdk/packages.txt -o bazel-out/darwin-dbg/bin/external/bazel_gazelle/language/go/gen_std_package_list/darwin_amd64_debug/gen_std_package_list -main bazel-out/darwin-dbg/bin/external/bazel_gazelle/language/go/gen_std_package_list/darwin_amd64_debug/gen_std_package_list%/github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.a -p github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list -- -extld external/local_config_cc/cc_wrapper.sh '-buildid=redacted' -extldflags '-fobjc-link-runtime -headerpad_max_install_names -no-canonical-prefixes -mmacosx-version-min=10.14')
Execution platform: @bazel_tools//platforms:host_platform

Use --sandbox_debug to see verbose messages from the sandbox
runtime.main_main·f: function main is undeclared in the main package
link: error running subcommand: exit status 2
Target @bazel_gazelle//language/go/gen_std_package_list:gen_std_package_list failed to build
INFO: Elapsed time: 0.415s, Critical Path: 0.27s
INFO: 0 processes.
FAILED: Build did NOT complete successfully

The text was updated successfully, but these errors were encountered:

steeve · 2019-07-11T11:26:38Z

If I do:

$ go tool nm bazel-out/host/bin/external/bazel_gazelle/language/go/gen_std_package_list/darwin_amd64_stripped/gen_std_package_list%/github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.a | grep main
    1b29 T github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.main
    4373 R github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.main.stkobj
    35c6 ? go.info.github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.main
    3ab5 ? go.isstmt.github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.main
    29b6 ? go.loc.github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.main
    3835 ? go.range.github.com/bazelbuild/bazel-gazelle/language/go/gen_std_package_list.main

Perhaps it's linked to the -main arg ?

steeve · 2019-07-11T11:55:59Z

I can repro with stock go:

$ cat main.go
package main

func main() {
	println("1")
}
$ go1.13beta1 tool compile -p mytest.com/pkg -pack main.go
$ go1.13beta1 tool link main.a
runtime.main_main·f: function main is undeclared in the main package
$ go tool nm main.a
         U
     409 R gclocals·33cdeccccebe80329f1fdbee7f5874cb
     411 R gclocals·9fb7f0986f647f17cb53dda1484e0f7a
     3be ? go.cuinfo.packagename.mytest.com/pkg
     3c5 ? go.info.mytest.com/pkg.main
     3e6 ? go.isstmt.mytest.com/pkg.main
     3c5 ? go.loc.mytest.com/pkg.main
     3e6 ? go.range.mytest.com/pkg.main
     3c2 R go.string."1"
     3c3 R go.string."1\n"
         U gofile../Users/steeve/go/src/github.com/steeve/test/main.go
     3f1 ? mytest.com/pkg..inittask
     345 T mytest.com/pkg.main <-------------------------------------------------------
         U runtime.morestack_noctxt
         U runtime.printlock
         U runtime.printstring
         U runtime.printunlock

Removing -p makes it work:

$ go1.13beta1 tool compile -pack main.go
$ go1.13beta1 tool link main.a
$ go tool nm main.a
         U
     39b ? %22%22..inittask
     2ef T %22%22.main <-------------------------------------------------------
     3b3 R gclocals·33cdeccccebe80329f1fdbee7f5874cb
     3bb R gclocals·9fb7f0986f647f17cb53dda1484e0f7a
     368 ? go.cuinfo.packagename.
     36f ? go.info.%22%22.main
     390 ? go.isstmt.%22%22.main
     36f ? go.loc.%22%22.main
     390 ? go.range.%22%22.main
     36c R go.string."1"
     36d R go.string."1\n"
         U gofile../Users/steeve/go/src/github.com/steeve/test/main.go
         U runtime.morestack_noctxt
         U runtime.printlock
         U runtime.printstring
         U runtime.printunlock

steeve · 2019-07-11T12:02:06Z

Adding packagefile main=main.a to the importcfg doesn't cut it

steeve · 2019-07-11T12:16:23Z

On go 1.12:

$ go tool nm main.a
         U
     3b6 T %22%22.init
     493 B %22%22.initdone·
     33d T %22%22.main
     493 R gclocals·33cdeccccebe80329f1fdbee7f5874cb
     49b R gclocals·9fb7f0986f647f17cb53dda1484e0f7a
     45f ? go.info.%22%22.init
     433 ? go.info.%22%22.main
     480 ? go.isstmt.%22%22.init
     454 ? go.isstmt.%22%22.main
     45f ? go.loc.%22%22.init
     433 ? go.loc.%22%22.main
     480 ? go.range.%22%22.init
     454 ? go.range.%22%22.main
     430 R go.string."1"
     431 R go.string."1\n"
         U gofile../Users/steeve/go/src/github.com/znly/gna/main.go
         U gofile..<autogenerated>
         U runtime.morestack_noctxt
         U runtime.printlock
         U runtime.printstring
         U runtime.printunlock
         U runtime.throwinit

jayconrod · 2019-07-11T15:40:11Z

Thanks for analyzing this. This looks like a bug in rules_go. I'll fix it before go1.13 is officially released, but probably not before rules_go 0.19.0 is released.

steeve · 2019-07-11T17:02:49Z

Thank you !

steeve · 2019-07-11T17:10:38Z

@jayconrod how would you go about fixing it? have gazelle generate importpath = "main" ?

jayconrod · 2019-07-11T17:22:37Z

I won't be able to look at it today, but I think go_binary and go_test will indicate somehow when calling go.archive that it's a main package. That will override -p. No user-facing change should be needed.

Go 1.13 is stricter on the package path passed to go tool compile -p. This means that go_library passed in go_binary.embed fails to declare a main.main function, as they now retain their original import path. Fix that by adding a is_main boolean to the GoLibrary provider, which will tell wether a library is supposed to be a main package; that is, compiled from within a go_binary. Fixes #2133

) Go 1.13 is stricter on the package path passed to go tool compile -p. This means that go_library passed in go_binary.embed fails to declare a main.main function, as they now retain their original import path. Fix that by adding a is_main boolean to the GoLibrary provider, which will tell wether a library is supposed to be a main package; that is, compiled from within a go_binary. Fixes bazel-contrib#2133

steeve mentioned this issue Jul 11, 2019

go1.13b1 tool compile -p breaks main packages golang/go#33055

Closed

jayconrod added bug go labels Jul 11, 2019

steeve mentioned this issue Jul 12, 2019

Ensure go_binary.embed libraries' importpath is main #2135

Merged

jayconrod closed this as completed in #2135 Jul 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go 1.13 compat #2133

go 1.13 compat #2133

steeve commented Jul 11, 2019 •

edited

Loading

steeve commented Jul 11, 2019

steeve commented Jul 11, 2019 •

edited

Loading

steeve commented Jul 11, 2019

steeve commented Jul 11, 2019

jayconrod commented Jul 11, 2019

steeve commented Jul 11, 2019

steeve commented Jul 11, 2019

jayconrod commented Jul 11, 2019

go 1.13 compat #2133

go 1.13 compat #2133

Comments

steeve commented Jul 11, 2019 • edited Loading

What version of rules_go are you using?

What version of gazelle are you using?

What version of Bazel are you using?

What operating system and processor architecture are you using?

What did you do?

What did you see instead?

steeve commented Jul 11, 2019

steeve commented Jul 11, 2019 • edited Loading

steeve commented Jul 11, 2019

steeve commented Jul 11, 2019

jayconrod commented Jul 11, 2019

steeve commented Jul 11, 2019

steeve commented Jul 11, 2019

jayconrod commented Jul 11, 2019

steeve commented Jul 11, 2019 •

edited

Loading

steeve commented Jul 11, 2019 •

edited

Loading