Skip to content

Commit

Permalink
go_download_sdk: workaround bug in ctx.download_and_extract (#1887)
Browse files Browse the repository at this point in the history
Workaround for bazelbuild/bazel#7055

Fixes #1880
  • Loading branch information
jayconrod authored Jan 7, 2019
1 parent b463dbf commit 3ac08dd
Showing 1 changed file with 21 additions and 5 deletions.
26 changes: 21 additions & 5 deletions go/private/sdk.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,27 @@ def _register_toolchains(repo):
native.register_toolchains(*labels)

def _remote_sdk(ctx, urls, strip_prefix, sha256):
ctx.download_and_extract(
url = urls,
stripPrefix = strip_prefix,
sha256 = sha256,
)
if ctx.os.name == "mac os x":
# TODO(bazelbuild/bazel#7055): download_and_extract fails to extract
# archives containing files with non-ASCII names. Go 1.12b1 has a test
# file like this. Remove this workaround when the bug is fixed.
if strip_prefix != "go":
fail("strip_prefix not supported on macOS")
ctx.download(
url = urls,
sha256 = sha256,
output = "go_sdk.tar.gz",
)
res = ctx.execute(["tar", "-xf", "go_sdk.tar.gz", "--strip-components=1"])
if res.return_code:
fail("error extracting Go SDK:\n" + res.stdout + res.stderr)
ctx.execute(["rm", "go_sdk.tar.gz"])
else:
ctx.download_and_extract(
url = urls,
stripPrefix = strip_prefix,
sha256 = sha256,
)

def _local_sdk(ctx, path):
for entry in ["src", "pkg", "bin"]:
Expand Down

0 comments on commit 3ac08dd

Please sign in to comment.